-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump github.com/Azure/azure-sdk-to-go/sdk/resourcemanager/containerservice/armcontainerservice/v4 to v4.4.0-beta.2 #4036
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4036 +/- ##
==========================================
+ Coverage 57.62% 57.63% +0.01%
==========================================
Files 188 188
Lines 19202 19202
==========================================
+ Hits 11065 11067 +2
+ Misses 7507 7505 -2
Partials 630 630 ☔ View full report in Codecov by Sentry. |
/retest |
c0b2d02
to
5cc01e1
Compare
go.mod
Outdated
@@ -9,7 +9,7 @@ require ( | |||
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.3.1 | |||
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/authorization/armauthorization/v2 v2.1.1 | |||
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5 v5.2.0 | |||
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerservice/armcontainerservice/v4 v4.3.0 | |||
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerservice/armcontainerservice/v4 v4.4.0-beta.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
I don't know that we want to bump to beta releases of the SDK. What are the support guarantees around beta releases? Are they subject to breaking changes?
related to #2625
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want to do this either; I created this PR partially to raise the question and partially to see if there are any technical issues for CAPZ using the beta release.
…rvice/armcontainerservice/v4 to v4.4.0-beta.1
…rvice/armcontainerservice/v4 to v4.4.0-beta.2
5cc01e1
to
d1746cb
Compare
/retitle bump github.com/Azure/azure-sdk-to-go/sdk/resourcemanager/containerservice/armcontainerservice/v4 to v4.4.0-beta.2 |
/close See #4069 |
@mboersma: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates AKS to the latest beta API. See release notes here: https://github.com/Azure/azure-sdk-for-go/releases?q=armcontainerservice&expanded=true
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
TODOs:
Release note: