Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump github.com/Azure/azure-sdk-to-go/sdk/resourcemanager/containerservice/armcontainerservice/v4 to v4.4.0-beta.2 #4036

Closed
wants to merge 2 commits into from

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates AKS to the latest beta API. See release notes here: https://github.com/Azure/azure-sdk-for-go/releases?q=armcontainerservice&expanded=true

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a73db19) 57.62% compared to head (d1746cb) 57.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4036      +/-   ##
==========================================
+ Coverage   57.62%   57.63%   +0.01%     
==========================================
  Files         188      188              
  Lines       19202    19202              
==========================================
+ Hits        11065    11067       +2     
+ Misses       7507     7505       -2     
  Partials      630      630              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonasingh46
Copy link
Contributor

/retest

go.mod Outdated
@@ -9,7 +9,7 @@ require (
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.3.1
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/authorization/armauthorization/v2 v2.1.1
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5 v5.2.0
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerservice/armcontainerservice/v4 v4.3.0
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerservice/armcontainerservice/v4 v4.4.0-beta.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I don't know that we want to bump to beta releases of the SDK. What are the support guarantees around beta releases? Are they subject to breaking changes?

related to #2625

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to do this either; I created this PR partially to raise the question and partially to see if there are any technical issues for CAPZ using the beta release.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023
…rvice/armcontainerservice/v4 to v4.4.0-beta.1
…rvice/armcontainerservice/v4 to v4.4.0-beta.2
@mboersma
Copy link
Contributor Author

/retitle bump github.com/Azure/azure-sdk-to-go/sdk/resourcemanager/containerservice/armcontainerservice/v4 to v4.4.0-beta.2

@k8s-ci-robot k8s-ci-robot changed the title bump github.com/Azure/azure-sdk-to-go/sdk/resourcemanager/containerservice/armcontainerservice/v4 to v4.4.0-beta.1 bump github.com/Azure/azure-sdk-to-go/sdk/resourcemanager/containerservice/armcontainerservice/v4 to v4.4.0-beta.2 Oct 10, 2023
@mboersma
Copy link
Contributor Author

/close

See #4069

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closed this PR.

In response to this:

/close

See #4069

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma mboersma deleted the aks-bleeding-edge branch October 16, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants