-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mount options for fsGroup delegation must ensure RWX for the group #848
fix: mount options for fsGroup delegation must ensure RWX for the group #848
Conversation
Hi @mpatlasov. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pull Request Test Coverage Report for Build 11385152781Details
💛 - Coveralls |
/ok-to-test |
If user sets `fsGroup: <gid>` in Pod's spec.securityContext, kubelet delegate fsGroup to CSI Driver, and NodeStageVolume() adds `gid=<gid>` to mount options. This might be not enough to make volume writable for the user: ``` $ kubectl exec fedora -- ls -ld /mnt/claim drwxr-xr-x. 2 root 1002 0 Sep 13 12:04 /mnt/claim $ kubectl exec fedora -- touch /mnt/claim/FILE touch: cannot touch '/mnt/claim/FILE': Permission denied ``` See kubernetes-csi#835
b5b4ae3
to
ce00f0e
Compare
/retest |
1 similar comment
/retest |
ce00f0e
to
93acf41
Compare
Last force-push: fixed spelling in nodeserver_test.go (s/rasing/raising) |
/test pull-csi-driver-smb-e2e-windows-2019 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
If user sets
fsGroup: <gid>
in Pod's spec.securityContext, kubelet delegate fsGroup to CSI Driver, and NodeStageVolume() addsgid=<gid>
to mount options. This might be not enough to make volume writable for the user:/kind bug
Fixes #835
Release note: