Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes deprecated function #2280 #2287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removes deprecated function #2280 #2287

wants to merge 1 commit into from

Conversation

poorvaja-s-hub
Copy link

@poorvaja-s-hub poorvaja-s-hub commented Sep 25, 2024 •
edited
Loading

What type of PR is this?

kind/bug

What this PR does / why we need it:

Removes deprecated function

Which issue(s) this PR fixes:

Fixes #2280

Special notes for your reviewer: NONE

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 25, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 25, 2024 •
edited
Loading

CLA Signed

  • ✅login: poorvaja-s-hub / (d91a39a)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: poorvaja-s-hub
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from yliaog September 25, 2024 13:04
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @poorvaja-s-hub!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 25, 2024
@poorvaja-s-hub poorvaja-s-hub changed the title Fixes #2280 Remove deprecated function Fixes #2280 Remove deprecated function kind/bug Sep 25, 2024
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 25, 2024
@poorvaja-s-hub poorvaja-s-hub changed the title Fixes #2280 Remove deprecated function kind/bug Removes deprecated function #2280 Sep 25, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 25, 2024
@roycaihw
Copy link
Member

/assign

roycaihw
roycaihw reviewed Sep 25, 2024
View reviewed changes
kubernetes/client/rest.py
@@ -39,10 +39,7 @@ def __init__(self, resp):
self.reason = resp.reason
self.data = resp.data

def getheaders(self):
"""Returns a dictionary of the response headers."""
return self.urllib3_response.getheaders()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated by openapi-generator. Has this method been removed in a newer version of the generator? If so, was there a replacement?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, is it okay to simply drop this method? I'd expect that there are other places depending on this, and would be broken if we simply drop this method.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used e.g. here: https://github.com/kubernetes-client/python/blob/master/kubernetes/client/exceptions.py#L91

I would rather suggest to keep and fix it. e.g.

    def getheaders(self):
        """Returns a dictionary of the response headers."""
        return self.urllib3_response.headers

kubernetes/client/rest.py
@@ -39,10 +39,7 @@ def __init__(self, resp):
self.reason = resp.reason
self.data = resp.data

def getheaders(self):
"""Returns a dictionary of the response headers."""
return self.urllib3_response.getheaders()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One alternative is to restrict the version of urllib3 that this client can support (< 2.0.0). That doesn't seem to be a good user experience. I'm not sure what's the adoption rate of urllib3 >= 2.0.0 as of today. cc @yliaog

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. 2.0.0 has been released for over a year: https://pypi.org/project/urllib3/#history

@vittoriocanilli
Copy link

@poorvaja-s-hub @roycaihw Any update on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afeblot afeblot afeblot left review comments

@roycaihw roycaihw roycaihw left review comments

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getheaders is deprecated in urllib3 >= 2.0.0
5 participants
@poorvaja-s-hub @k8s-ci-robot @roycaihw @vittoriocanilli @afeblot