-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix package version mismatch #1580
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1580 +/- ##
=========================================
Coverage ? 61.50%
=========================================
Files ? 103
Lines ? 3068
Branches ? 639
=========================================
Hits ? 1887
Misses ? 1181
Partials ? 0 ☔ View full report in Codecov by Sentry. |
any idea why this caused the breaking? From the CI job: https://github.com/kubernetes-client/csharp/actions/runs/10342522725/job/28625566944 the version is the same as the nuget package version, maybe not related to the change @tg123 https://github.com/kubernetes-client/csharp/actions/runs/10356053821/job/28665066544 How was the release generated? Seemed I could not find the CI which created the release Could it relate to the Github release build error |
i did git bisect, i have no idea why |
wired that from my test, the same version produced for both release and nuget package from the same commit |
@tg123 would you mind trying to trigger a release to verify whether we still have this issue, maybe we could wait until the v1.31 is ready |
sure i did the test locally, seems you are right, it is due to tag not created |
fix #1575
regression introduced by #1565