Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package version mismatch #1580

Closed
wants to merge 1 commit into from
Closed

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Sep 7, 2024

fix #1575

regression introduced by #1565

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@36a0204). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1580   +/-   ##
=========================================
  Coverage          ?   61.50%           
=========================================
  Files             ?      103           
  Lines             ?     3068           
  Branches          ?      639           
=========================================
  Hits              ?     1887           
  Misses            ?     1181           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tg123 tg123 assigned tg123 and unassigned tg123 Sep 7, 2024
@WeihanLi
Copy link
Contributor

WeihanLi commented Sep 8, 2024

any idea why this caused the breaking?

From the CI job: https://github.com/kubernetes-client/csharp/actions/runs/10342522725/job/28625566944

image

the version is the same as the nuget package version, maybe not related to the change @tg123

https://github.com/kubernetes-client/csharp/actions/runs/10356053821/job/28665066544

How was the release generated? Seemed I could not find the CI which created the release

Could it relate to the Github release build error

@tg123
Copy link
Member Author

tg123 commented Sep 8, 2024

i did git bisect,
create a tag for each local build test, found that the pr breaks it

i have no idea why

@WeihanLi
Copy link
Contributor

WeihanLi commented Sep 8, 2024

wired that from my test, the same version produced for both release and nuget package from the same commit

@WeihanLi
Copy link
Contributor

WeihanLi commented Sep 8, 2024

@tg123 would you mind trying to trigger a release to verify whether we still have this issue, maybe we could wait until the v1.31 is ready

@tg123
Copy link
Member Author

tg123 commented Sep 8, 2024

sure i did the test locally, seems you are right, it is due to tag not created

@tg123 tg123 marked this pull request as draft September 8, 2024 08:33
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2024
@tg123 tg123 closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuget package is versioned differently to GitHub
4 participants