Labeling the Controle plane nodes before start applying addons and Helm releases #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
|
Skipping CI for Draft Pull Request. |
kubermatic-bot
added
size/S
|
/assign |
|
/release-note-edit |
|
LGTM label has been added. Git tree hash: 39551dcc5786822f9cf2e80662148b30439c5d73
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/remove-kind bug |
kubermatic-bot
added
kind/feature
|
/retest |
xmudrii
pushed a commit
that referenced
this pull request
Jan 30, 2025
kubermatic-bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
…branch (#3547) * feat: add flag to skip TLS verification (#3522) * feat: add flag to skip TLS verification Signed-off-by: Stephan <[email protected]> * Update addons/backups-restic/backups-restic.yaml Co-authored-by: Artiom Diomin <[email protected]> Signed-off-by: Stephan <[email protected]> --------- Signed-off-by: Stephan <[email protected]> Co-authored-by: Artiom Diomin <[email protected]> * fix cloud config defaulting before terraform config apply (#3534) * Make sure no slash at the end of vcenterPrefix (#3537) Signed-off-by: Artiom Diomin <[email protected]> * Fix kubevirt csi addon template (#3529) * fix kubevirt csi addon template * update internal images in template * update internal images in template * fix labels * update addons * update addons sa * fix toleration (#3545) * update Machine controller image (#3546) * update Machine controller image Signed-off-by: Mohamed Rafraf <[email protected]> * update go.mod --------- Signed-off-by: Mohamed Rafraf <[email protected]> * labeling control-plane before (#3544) --------- Signed-off-by: Stephan <[email protected]> Signed-off-by: Artiom Diomin <[email protected]> Signed-off-by: Mohamed Rafraf <[email protected]> Co-authored-by: Stephan <[email protected]> Co-authored-by: Artiom Diomin <[email protected]> Co-authored-by: Mohamed Rafraf <[email protected]> Co-authored-by: Artiom Diomin <[email protected]>
|
/cherrypick release/v1.8 |
|
@xmudrii: new pull request created: #3553 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Kube-OVN, as the CNI, requires specific node labels, but these labels are applied only after CCM ensures the nodes. However, CCM isn’t deployed because the CNI is unhealthy, creating a deadlock.
To resolve this, we label control-plane nodes before applying addons and Helm releases, ensuring a smooth bootstrap process. 🚀
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: