Update Kubeflow Pipelines Legacy V1 warning text #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
force-pushed
the
fix-v1-kfp-docs-warning
branch
from
d72442c to
b1bcf4c
Compare
Signed-off-by: Mathew Wicks <[email protected]>
|
@hbelmiro if you agree with this wording, we can merge this update. |
hbelmiro
approved these changes
Jul 6, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL #3791 has been merged(I don't want to break that revert, so I will update this PR to also update the warnings on those pages after that PR is merged).
This PR updates the warning in the
"Kubeflow Pipelines"/"Legacy (v1)"section to be more useful, this new text is much more helpful and explains more about what they need to do to migrate.The original PR that added this text #3775 was seemingly merged without responding to review comments.
I have also removed the "stable status" notice on some of the KFP v1 pages, as the component is now deprecated.