Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: fix the minResources calculation logic of podgroup for volcano #2262

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kaka-zb
Copy link
Contributor

@kaka-zb kaka-zb commented Oct 18, 2024

Purpose of this PR

As described in #2244, the spark.dynamicAllocation.* & spark.kubernetes.memoryOverheadFactor params of spark are not taken into account when calculating memory of minResources for volcano podGroup, so i created this PR and see if that helps. And then we can consider extracting resourceusage module to the scheduler directory.

Note that only cluster deploy mode is considered in this PR, after resourceusage module is extracted, i can import resourceusage module in volcano package and fix the minResources calculation logic in both cluster deploy mode and client deploy mode.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yuchaoran2011 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaka-zb
Copy link
Contributor Author

kaka-zb commented Oct 18, 2024

@jacobsalway, please take a look when you're free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants