Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(components): move old components to contrib folder #11315

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

chensun
Copy link
Member

@chensun chensun commented Oct 18, 2024

Moving components that has no maintenance activities in the past two years to the contrib folder.

Description of your changes:

Checklist:

Moving components that as no maintenance activities in the past two
years to contrib folder.

Signed-off-by: Chen Sun <[email protected]>
@HumairAK
Copy link
Collaborator

I think my overall preference is to remove these entirely to lower maintenance burden, as well as reduce noise from security scan software, but this works too.

/lgtm
/approve

related: #11145

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 187ecd0 into kubeflow:master Oct 21, 2024
3 checks passed
@chensun chensun deleted the clean-up-components branch October 23, 2024 00:50
@Fiona-Waters
Copy link
Contributor

I currently have this PR updating the pytorch-launcher component. Is this work still relevant?
Related issue
@anishasthana @HumairAK @chensun
cc @Shreyanand

@HumairAK
Copy link
Collaborator

@Fiona-Waters yes, absolutely, in this case my suggestion is to rebase and just re-add the files that are being updated, but not the files that have not been updated in a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants