Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subdagio #11228

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Subdagio #11228

wants to merge 8 commits into from
+360 −60

Conversation

CarterFendley
Copy link
Contributor

Testing test modifications before pushing to #11196

droctothorpe and others added 6 commits September 11, 2024 12:55
@droctothorpe @zazulam @CarterFendley
fix(backend): implement subdag output resolution
1e62d0d 
Signed-off-by: droctothorpe <[email protected]>
Co-authored-by: zazulam <[email protected]>
Co-authored-by: CarterFendley <[email protected]>
@droctothorpe @zazulam @CarterFendley
Add support for subdags of subdags
a0a7b7b 
Signed-off-by: droctothorpe <[email protected]>
Co-authored-by: zazulam <[email protected]>
Co-authored-by: CarterFendley <[email protected]>
@zazulam @droctothorpe
handle edge case
1cb4db8 
Signed-off-by: zazulam <[email protected]>
Co-authored-by: droctothorpe <[email protected]>
@droctothorpe @zazulam
@CarterFendley @edmondop
Handle artifact outputs as well
d920cf1 
Signed-off-by: droctothorpe <[email protected]>
Co-authored-by: zazulam <[email protected]>
Co-authored-by: CarterFendley <[email protected]>
Co-authored-by: edmondop <[email protected]>
@droctothorpe @zazulam
Simplify parameter handling logic
ee7f6c9 
Signed-off-by: droctothorpe <[email protected]>
Co-authored-by: zazulam <[email protected]>
@droctothorpe
Begin decomposition
217ff0d 
Signed-off-by: droctothorpe <[email protected]>
@google-oss-prow Google OSS Prow
Copy link

Hi @CarterFendley. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK modified the milestone: KFP 2.4.0 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@HumairAK HumairAK Awaiting requested review from HumairAK

Assignees
No one assigned
Labels
needs-ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CarterFendley @HumairAK @droctothorpe @zazulam