Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fixes flaky tests in CompareV2 resulting in false failures in PRs. Fixes #10811 #11170

Conversation

ElayAharoni
Copy link
Contributor

@ElayAharoni ElayAharoni commented Sep 5, 2024

fixes #10811.

first trying to see all the flaky tests.

Copy link

Hi @ElayAharoni. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@ElayAharoni: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@ElayAharoni: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hbelmiro
Copy link
Contributor

hbelmiro commented Sep 5, 2024

/ok-to-test
/rerun-all

@hbelmiro
Copy link
Contributor

hbelmiro commented Sep 5, 2024

@ElayAharoni please link the PR to the issue using a keyword.

@hbelmiro
Copy link
Contributor

hbelmiro commented Sep 5, 2024

/ok-to-test
/rerun-all

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
@ElayAharoni
Copy link
Contributor Author

/rerun-all

1 similar comment
@hbelmiro
Copy link
Contributor

hbelmiro commented Sep 5, 2024

/rerun-all

@hbelmiro
Copy link
Contributor

hbelmiro commented Sep 5, 2024

/ok-to-test
/rerun-all

@ElayAharoni ElayAharoni closed this Sep 5, 2024
@ElayAharoni ElayAharoni reopened this Sep 5, 2024
Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
@ElayAharoni
Copy link
Contributor Author

/rerun-all

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ElayAharoni ElayAharoni marked this pull request as ready for review September 5, 2024 14:27
@ElayAharoni
Copy link
Contributor Author

tried to reproduce the flaky tests with no success.
3 times via pushing here and each time all the tests passed.
and 5 more times locally also did not see the flaky tests.

might be not-reproduceable

@hbelmiro
Copy link
Contributor

hbelmiro commented Sep 5, 2024

@HumairAK given the comment above, do you feel like we can close #10884?

@ElayAharoni
Copy link
Contributor Author

@HumairAK , @hbelmiro , what do you think? can we close the issue?

@HumairAK
Copy link
Collaborator

HumairAK commented Sep 9, 2024

Thanks @ElayAharoni I've closed it out.

@HumairAK
Copy link
Collaborator

HumairAK commented Sep 9, 2024

/close

Copy link

@HumairAK: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontend] Flaky tests in CompareV2 resulting in false failures in PRs
3 participants