Add-Create-Experiment-button-when-selecting-experiement-#5737 #11060

ElayAharoni · 2024-07-31T17:44:32Z

feat(frontend): add create experiment button when selecting experiment.

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>

google-oss-prow · 2024-07-31T17:44:42Z

Hi @ElayAharoni. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hbelmiro · 2024-07-31T18:32:35Z

/ok-to-test
/rerun-all

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737 # Conflicts: # frontend/src/pages/NewRunV2.tsx # frontend/src/pages/functional_components/NewExperimentFC.tsx

ElayAharoni · 2024-08-01T07:35:11Z

i fixed the formatting of the code, please if i can have a second review. thanks

hbelmiro · 2024-08-01T11:08:01Z

/rerun-all

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

ElayAharoni · 2024-08-01T11:48:55Z

thanks, i had one more lint issue that i missed.. can you please retrigger the tests whenever you can?
or am i authorized to do so myself?

hbelmiro · 2024-08-01T13:55:33Z

/rerun-all

@ElayAharoni you may be authorized to retrigger them. I'm not sure.
Next time can you please try it by adding a /rerun-all comment?

hbelmiro · 2024-08-01T13:58:49Z

/rerun-all

ElayAharoni · 2024-08-04T07:42:11Z

hi the pr has passed the tests, if i can have another review please.
Please let me know if there is anything else to do before merge.
thanks

ElayAharoni · 2024-08-07T08:48:49Z

hi is there any progress with the review of the pr? please let me know if there is anything i need to do

ElayAharoni · 2024-08-15T08:42:45Z

please if someone can review the PR when possible.
@zijianjoy , @HumairAK

…flow#11231) Signed-off-by: Chen Sun <[email protected]>

…flow#11127) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.5 to 6.5.7. - [Commits](indutny/elliptic@v6.5.5...v6.5.7) --- updated-dependencies: - dependency-name: elliptic dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…n /frontend/server (kubeflow#11056) Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) to 4.4.1 and updates ancestor dependency [@aws-sdk/credential-providers](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/credential-providers). These dependencies need to be updated together. Updates `fast-xml-parser` from 4.2.5 to 4.4.1 - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v4.2.5...v4.4.1) Updates `@aws-sdk/credential-providers` from 3.359.0 to 3.621.0 - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/credential-providers/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.621.0/packages/credential-providers) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-type: indirect - dependency-name: "@aws-sdk/credential-providers" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [send](https://github.com/pillarjs/send) to 0.19.0 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together. Updates `send` from 0.18.0 to 0.19.0 - [Release notes](https://github.com/pillarjs/send/releases) - [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md) - [Commits](pillarjs/send@0.18.0...0.19.0) Updates `express` from 4.20.0 to 4.21.0 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/express@4.20.0...4.21.0) --- updated-dependencies: - dependency-name: send dependency-type: indirect - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

This commit adds a github workflow that will build v2 images and push them to GHCR. It uses the GITHUB_TOKEN to authenticate and uses docker provisioned github actions to streamline the flow. The workflow also creates attestations for the packages which can be used to verify provenance and integrity. The workflow can be triggered manually or via another workflow call. The latter is to supplement future automation flows. Signed-off-by: Humair Khan <[email protected]>

…flow#11294) * Use kustomize to patch deployments before deploy Signed-off-by: carter.fendley <[email protected]> * Relocate scripts / manifests to github directory Signed-off-by: carter.fendley <[email protected]> --------- Signed-off-by: carter.fendley <[email protected]>

…11306) Signed-off-by: Helber Belmiro <[email protected]>

) Moving components that as no maintenance activities in the past two years to contrib folder. Signed-off-by: Chen Sun <[email protected]>

) Signed-off-by: VaniHaripriya <[email protected]>

* fix(tests): remove redundant integration test wf Signed-off-by: droctothorpe <[email protected]> * Add paths Signed-off-by: droctothorpe <[email protected]> * Remove integration-test.sh Signed-off-by: droctothorpe <[email protected]> --------- Signed-off-by: droctothorpe <[email protected]>

hbelmiro · 2024-10-25T13:41:59Z

@ElayAharoni it's been waiting for some time. Can you rebase?
@HumairAK do you have this on your plate?

* adding chore as a new template Signed-off-by: varodrig <[email protected]> * Update .github/ISSUE_TEMPLATE/CHORE.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Valentina Rodriguez Sosa <[email protected]> * Update .github/ISSUE_TEMPLATE/CHORE.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Valentina Rodriguez Sosa <[email protected]> * Update .github/ISSUE_TEMPLATE/CHORE.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Valentina Rodriguez Sosa <[email protected]> * Update .github/ISSUE_TEMPLATE/CHORE.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Valentina Rodriguez Sosa <[email protected]> * Update .github/ISSUE_TEMPLATE/CHORE.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Valentina Rodriguez Sosa <[email protected]> * Update .github/ISSUE_TEMPLATE/CHORE.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Valentina Rodriguez Sosa <[email protected]> --------- Signed-off-by: varodrig <[email protected]> Signed-off-by: Valentina Rodriguez Sosa <[email protected]> Co-authored-by: Helber Belmiro <[email protected]>

HumairAK · 2024-10-25T20:29:37Z

Tested and works,

/lgtm

@ElayAharoni apologies for the wait, can you rebase? once done I can merge this.

ElayAharoni · 2024-10-28T09:27:06Z

hi @HumairAK sorry for the delay, i did rebase now

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737 # Conflicts: # frontend/src/pages/NewRunV2.tsx

google-oss-prow · 2024-10-28T10:41:08Z

New changes are detected. LGTM label has been removed.

google-oss-prow · 2024-10-28T10:41:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737 # Conflicts: # frontend/src/pages/NewRunV2.tsx

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

hbelmiro · 2024-10-28T12:01:00Z

@ElayAharoni 48 commits. It seems like the rebase was not properly done.

ElayAharoni · 2024-10-28T12:31:45Z

yeah i did something wrong when rebased it, i will drop this pr and created a new one for this issue..
new pr link: #11332

hbelmiro · 2024-10-28T12:33:50Z

/close

google-oss-prow · 2024-10-28T12:33:55Z

@hbelmiro: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

19607a2

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>

google-oss-prow bot requested review from HumairAK and zijianjoy July 31, 2024 17:44

google-oss-prow bot added the size/M label Jul 31, 2024

google-oss-prow bot added the needs-ok-to-test label Jul 31, 2024

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Jul 31, 2024

Elay Aharoni (EXT-Nokia) added 2 commits July 31, 2024 22:18

Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

3289427

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>

google-oss-prow bot added size/L and removed size/M labels Jul 31, 2024

Elay Aharoni (EXT-Nokia) added 2 commits August 1, 2024 14:47

Merge remote-tracking branch 'origin/Add-Create-Experiment-button-whe…

a765a1e

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

Merge remote-tracking branch 'origin/Add-Create-Experiment-button-whe…

27b8be6

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

This was referenced Aug 20, 2024

Add ElayAharoni as member to kubeflow org kubeflow/internal-acls#697

Closed

Add ElayAharoni as member to kubeflow-org kubeflow/internal-acls#698

Merged

chensun and others added 5 commits September 20, 2024 19:08

fix(backend): upgrade PyYMAL to fix metadata_writer build error (kube…

a4119a6

…flow#11231) Signed-off-by: Chen Sun <[email protected]>

CarterFendley and others added 5 commits October 17, 2024 05:05

test: Disabled ci-check and add-ci-passed-label workflows. (kubeflow#…

c2a7713

…11306) Signed-off-by: Helber Belmiro <[email protected]>

chore(components): move old components to contrib folder (kubeflow#11315

187ecd0

) Moving components that as no maintenance activities in the past two years to contrib folder. Signed-off-by: Chen Sun <[email protected]>

test: Enabled ci-check and add-ci-passed-label workflows (kubeflow#11320

095a794

) Signed-off-by: VaniHaripriya <[email protected]>

google-oss-prow bot assigned HumairAK Oct 25, 2024

google-oss-prow bot added the lgtm label Oct 25, 2024

github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 25, 2024

Elay Aharoni (EXT-Nokia) added 3 commits October 28, 2024 12:29

Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

2e05705

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>

Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

c4f999e

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>

Merge remote-tracking branch 'origin/Add-Create-Experiment-button-whe…

ebc4058

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737 # Conflicts: # frontend/src/pages/NewRunV2.tsx

google-oss-prow bot added size/XXL and removed lgtm size/L labels Oct 28, 2024

Elay Aharoni (EXT-Nokia) added 4 commits October 28, 2024 12:44

Merge remote-tracking branch 'origin/Add-Create-Experiment-button-whe…

e05680e

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

Merge remote-tracking branch 'origin/Add-Create-Experiment-button-whe…

3161bb5

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737 # Conflicts: # frontend/src/pages/NewRunV2.tsx

Merge remote-tracking branch 'origin/Add-Create-Experiment-button-whe…

ad9e883

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

Merge remote-tracking branch 'origin/Add-Create-Experiment-button-whe…

4c4b893

…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

google-oss-prow bot closed this Oct 28, 2024

ElayAharoni deleted the Add-Create-Experiment-button-when-selecting-experiement-#5737 branch October 28, 2024 12:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add-Create-Experiment-button-when-selecting-experiement-#5737 #11060

Add-Create-Experiment-button-when-selecting-experiement-#5737 #11060

ElayAharoni commented Jul 31, 2024 •

edited

Loading

google-oss-prow bot commented Jul 31, 2024

hbelmiro commented Jul 31, 2024

ElayAharoni commented Aug 1, 2024

hbelmiro commented Aug 1, 2024

ElayAharoni commented Aug 1, 2024 •

edited

Loading

hbelmiro commented Aug 1, 2024 •

edited

Loading

hbelmiro commented Aug 1, 2024

ElayAharoni commented Aug 4, 2024 •

edited

Loading

ElayAharoni commented Aug 7, 2024

ElayAharoni commented Aug 15, 2024

hbelmiro commented Oct 25, 2024

HumairAK commented Oct 25, 2024

ElayAharoni commented Oct 28, 2024 •

edited

Loading

google-oss-prow bot commented Oct 28, 2024

google-oss-prow bot commented Oct 28, 2024

hbelmiro commented Oct 28, 2024

ElayAharoni commented Oct 28, 2024 •

edited

Loading

hbelmiro commented Oct 28, 2024

google-oss-prow bot commented Oct 28, 2024

Add-Create-Experiment-button-when-selecting-experiement-#5737 #11060

Add-Create-Experiment-button-when-selecting-experiement-#5737 #11060

Conversation

ElayAharoni commented Jul 31, 2024 • edited Loading

google-oss-prow bot commented Jul 31, 2024

hbelmiro commented Jul 31, 2024

ElayAharoni commented Aug 1, 2024

hbelmiro commented Aug 1, 2024

ElayAharoni commented Aug 1, 2024 • edited Loading

hbelmiro commented Aug 1, 2024 • edited Loading

hbelmiro commented Aug 1, 2024

ElayAharoni commented Aug 4, 2024 • edited Loading

ElayAharoni commented Aug 7, 2024

ElayAharoni commented Aug 15, 2024

hbelmiro commented Oct 25, 2024

HumairAK commented Oct 25, 2024

ElayAharoni commented Oct 28, 2024 • edited Loading

google-oss-prow bot commented Oct 28, 2024

google-oss-prow bot commented Oct 28, 2024

hbelmiro commented Oct 28, 2024

ElayAharoni commented Oct 28, 2024 • edited Loading

hbelmiro commented Oct 28, 2024

google-oss-prow bot commented Oct 28, 2024

ElayAharoni commented Jul 31, 2024 •

edited

Loading

ElayAharoni commented Aug 1, 2024 •

edited

Loading

hbelmiro commented Aug 1, 2024 •

edited

Loading

ElayAharoni commented Aug 4, 2024 •

edited

Loading

ElayAharoni commented Oct 28, 2024 •

edited

Loading

ElayAharoni commented Oct 28, 2024 •

edited

Loading