Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): IR -> Pipeline Spec #11031

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix(docs): IR -> Pipeline Spec #11031

merged 1 commit into from
Jul 26, 2024

Conversation

gregsheremeta
Copy link
Contributor

Description of your changes:
fix(docs): IR -> Pipeline Spec

Checklist:

@google-oss-prow Google OSS Prow
Copy link

@gregsheremeta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-execution-tests 6980d2f link false /test kfp-kubernetes-execution-tests
kubeflow-pipelines-sdk-execution-tests 6980d2f link true /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

hbelmiro
hbelmiro reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gregsheremeta fyi kubeflow-pipelines-sdk-execution-tests failure is fixed by #10975, which is blocked by GoogleCloudPlatform/oss-test-infra#2313, which is pending review from one of the approvers: @chensun @gkcalat @james-jwu @zijianjoy.

cc @DharmitD

@google-oss-prow google-oss-prow bot added the lgtm label Jul 23, 2024
chensun
chensun approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Contributor

/lgtm

@gregsheremeta fyi kubeflow-pipelines-sdk-execution-tests failure is fixed by #10975, which is blocked by GoogleCloudPlatform/oss-test-infra#2313, which is pending review from one of the approvers: @chensun @gkcalat @james-jwu @zijianjoy.

cc @DharmitD

@gregsheremeta the blocking PRs were merged. If you rebase it, it should be ready to merge.

@gregsheremeta
fix(docs): IR -> Pipeline Spec
b97367b 
Signed-off-by: Greg Sheremeta <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Jul 26, 2024
hbelmiro
hbelmiro reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 26, 2024
@rimolive
Copy link
Member

/lgtm

@VaniHaripriya
Copy link
Contributor

/lgtm

@google-oss-prow Google OSS Prow
Copy link

@VaniHaripriya: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

DharmitD
DharmitD reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@diegolovison
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot merged commit 1e95eb6 into kubeflow:master Jul 26, 2024
24 checks passed
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
@gregsheremeta @R3hankhan123
fix(docs): IR -> Pipeline Spec (kubeflow#11031)
f4e6004 
Signed-off-by: Greg Sheremeta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD DharmitD left review comments

@hbelmiro hbelmiro hbelmiro left review comments

@chensun chensun chensun approved these changes

@connor-mccarthy connor-mccarthy Awaiting requested review from connor-mccarthy

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@diegolovison diegolovison

@rimolive rimolive

@chensun chensun

@hbelmiro hbelmiro

@DharmitD DharmitD

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gregsheremeta @hbelmiro @rimolive @VaniHaripriya @diegolovison @chensun @DharmitD