-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Backend + SDK): Update kfp backend and kubernetes sdk to allow enabling shared memory #10704
base: master
Are you sure you want to change the base?
feat(Backend + SDK): Update kfp backend and kubernetes sdk to allow enabling shared memory #10704
Conversation
Hi @hsteude. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
95fb2ae
to
6e158ce
Compare
@hsteude Can you please add this PR as a topic to the next Pipelines WG meeting? |
1916727
to
9268be2
Compare
b741f97
to
0549ca3
Compare
Any update on this? Would be really nice to have. |
/ok-to-test |
@hsteude: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@rimolive @chensun @zijianjoy @james-jwu Would really appreciate a review on this. |
Hi all, any plans to merge it ? |
@hsteude can you please rebase so you get the latest changes on tests? |
0549ca3
to
960a965
Compare
Signed-off-by: hsteude <[email protected]>
Signed-off-by: hsteude <[email protected]>
960a965
to
9213ec7
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@HumairAK do you have this on your plate? |
This PR adds a method called 'enable_shared_memory' to the kubernetes_platform python sdk.
Why?
Without this, we can't train PyTorch models using dataloaders with multiple workers (see #9893).
Next Steps:
This PR has to be rebased once #10703 is merged. We'll also need to update the
go.mod
,go.sum
, and the license CSV files.Checklist: