fix(components): Use instance.target_field_name format for text-bison…

… models only, use target_field_name for gemini models Signed-off-by: Googler <[email protected]> PiperOrigin-RevId: 665638487
kubeflow · Aug 21, 2024 · 1a07ffa · 1a07ffa
1 parent 120a908
commit 1a07ffa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/...line_components/_implementation/model_evaluation/llm_evaluation_preprocessor/component.py b/...line_components/_implementation/model_evaluation/llm_evaluation_preprocessor/component.py
@@ -101,10 +101,8 @@ def evaluation_dataset_preprocessor_internal(
               f'--gcs_source_uris={gcs_source_uris}',
               f'--input_field_name={input_field_name}',
               f'--role_field_name={role_field_name}',
-              (
-                  f'--target_field_name={target_field_name}'
-                  f'--model_name={model_name}'
-              ),
+              f'--target_field_name={target_field_name}',
+              f'--model_name={model_name}',
               f'--output_dirs={output_dirs}',
               '--executor_input={{$.json_escape[1]}}',
           ],

diff --git a/..._cloud_pipeline_components/v1/model_evaluation/evaluation_llm_text_generation_pipeline.py b/..._cloud_pipeline_components/v1/model_evaluation/evaluation_llm_text_generation_pipeline.py
@@ -152,7 +152,7 @@ def evaluation_llm_text_generation_pipeline(  # pylint: disable=dangerous-defaul
       project=project,
       location=location,
       evaluation_task=evaluation_task,
-      target_field_name=f'instance.{target_field_name}',
+      target_field_name=target_field_name,
       predictions_format=batch_predict_predictions_format,
       enable_row_based_metrics=enable_row_based_metrics,
       joined_predictions_gcs_source=batch_predict_task.outputs[