feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column #148 #177
Conversation
liavweiss
force-pushed
the
kind_logo_modification/#148
branch
2 times, most recently
from
9ea0557 to
6fceada
Compare
There was a problem hiding this comment.
Thanks for the PR @liavweiss ! I've made a few comments inline, also please consider using the camel case [W|w]orkspaceKinds instead of [W|w]orkspacekinds for variable names where applicable.
node_modules/.package-lock.json
Outdated
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
This file should not be created. It was probably created because of an npm command being ran in the repository root.
package-lock.json
Outdated
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
This file should not be created. It was probably created because of an npm command being ran in the repository root.
| }, | ||
| options: { | ||
| imageConfig: { | ||
| default: string, |
There was a problem hiding this comment.
| default: string, | |
| spawner: { | |
| default: string, | |
| }, |
| displayName: string, | ||
| labels: { | ||
| pythonVersion: string | ||
| }, | ||
| hidden: true, |
There was a problem hiding this comment.
| displayName: string, | |
| labels: { | |
| pythonVersion: string | |
| }, | |
| hidden: true, | |
| spawner: { | |
| displayName: string, | |
| description: string, | |
| labels: [ | |
| { | |
| key: string, | |
| value: string; | |
| } | |
| ], | |
| hidden: true, | |
| } |
| ] | ||
| }, | ||
| podConfig: { | ||
| default: string, |
There was a problem hiding this comment.
| default: string, | |
| spawner: { | |
| default: string, | |
| }, |
| default: string, | ||
| values: [ | ||
| { | ||
| id: string, |
There was a problem hiding this comment.
This part is also not matching the CR structure here.
Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
…Kind column kubeflow#148 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
…Kind column kubeflow#148 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
…Kind column kubeflow#148 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
liavweiss
force-pushed
the
kind_logo_modification/#148
branch
from
dccf98e to
77d67cf
Compare
…Kind column kubeflow#148 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
…Kind column kubeflow#148 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
There was a problem hiding this comment.
@liavweiss thanks for the PR. Can we have a default logo (even just a placeholder) when the logo is not available? I think it would be a much better experience for the user then showing the 'broken' image.
…Kind column kubeflow#148 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
|
After Eder's comment and a discussion with Paulo and Jenny we agreed to have a default Icon in case we don't have icon for the specific kind |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, paulovmr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@liavweiss thank you for accommodating! |
|
/lgtm |
This pr also contains the implementation of fetch data from workspacekinds API, to be able to take the Icon URL.
In case we have an Icon:
In case we don't have an Icon(broken URL or Icon does not exist):
