Skip to content

feat(ws): Implement Start restart and stop workspace actions #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

feat(ws): Implement Start restart and stop workspace actions #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 114 additions & 40 deletions workspaces/frontend/src/app/pages/Workspaces/Workspaces.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import {
Pagination,
Button,
Content,
Tooltip,
Brand,
Tooltip,
} from '@patternfly/react-core';
import {
Table,
Expand All @@ -34,9 +34,21 @@ import DeleteModal from '~/shared/components/DeleteModal';
import { buildKindLogoDictionary } from '~/app/actions/WorkspaceKindsActions';
import useWorkspaceKinds from '~/app/hooks/useWorkspaceKinds';
import { WorkspaceConnectAction } from '~/app/pages/Workspaces/WorkspaceConnectAction';
import { WorkspaceStartActionModal } from '~/app/pages/Workspaces/workspaceActions/WorkspaceStartActionModal';
import { WorkspaceRestartActionModal } from '~/app/pages/Workspaces/workspaceActions/WorkspaceRestartActionModal';
import { WorkspaceStopActionModal } from '~/app/pages/Workspaces/workspaceActions/WorkspaceStopActionModal';
import Filter, { FilteredColumn } from 'shared/components/Filter';
import { formatRam } from 'shared/utilities/WorkspaceResources';

export enum ActionType {
ViewDetails,
Edit,
Delete,
Start,
Restart,
Stop,
}

export const Workspaces: React.FunctionComponent = () => {
/* Mocked workspaces, to be removed after fetching info from backend */
const mockWorkspaces: Workspace[] = [
Expand Down Expand Up @@ -85,7 +97,7 @@ export const Workspaces: React.FunctionComponent = () => {
lastUpdate: 0,
},
pauseTime: 0,
pendingRestart: false,
pendingRestart: true,
podTemplateOptions: {
imageConfig: {
desired: '',
Expand Down Expand Up @@ -170,7 +182,7 @@ export const Workspaces: React.FunctionComponent = () => {
lastActivity: 'Last Activity',
};

const filterableColumns: WorkspacesColumnNames = {
const filterableColumns = {
name: 'Name',
kind: 'Kind',
image: 'Image',
Expand All @@ -182,10 +194,12 @@ export const Workspaces: React.FunctionComponent = () => {

// change when fetch workspaces is implemented
const initialWorkspaces = mockWorkspaces;
const [workspaces, setWorkspaces] = useState(initialWorkspaces);
const [workspaces, setWorkspaces] = useState<Workspace[]>(initialWorkspaces);
const [expandedWorkspacesNames, setExpandedWorkspacesNames] = React.useState<string[]>([]);
const [selectedWorkspace, setSelectedWorkspace] = React.useState<Workspace | null>(null);
const [workspaceToDelete, setWorkspaceToDelete] = React.useState<Workspace | null>(null);
const [isActionAlertModalOpen, setIsActionAlertModalOpen] = React.useState(false);
const [activeActionType, setActiveActionType] = React.useState<ActionType | null>(null);

const selectWorkspace = React.useCallback(
(newSelectedWorkspace) => {
Expand All @@ -197,6 +211,7 @@ export const Workspaces: React.FunctionComponent = () => {
},
[selectedWorkspace],
);

const setWorkspaceExpanded = (workspace: Workspace, isExpanding = true) =>
setExpandedWorkspacesNames((prevExpanded) => {
const newExpandedWorkspacesNames = prevExpanded.filter((wsName) => wsName !== workspace.name);
Expand Down Expand Up @@ -300,20 +315,31 @@ export const Workspaces: React.FunctionComponent = () => {

// Actions

const viewDetailsClick = React.useCallback((workspace: Workspace) => {
setSelectedWorkspace(workspace);
setActiveActionType(ActionType.ViewDetails);
}, []);

const editAction = React.useCallback((workspace: Workspace) => {
console.log(`Clicked on edit, on row ${workspace.name}`);
setSelectedWorkspace(workspace);
setActiveActionType(ActionType.Edit);
}, []);

const deleteAction = React.useCallback((workspace: Workspace) => {
console.log(`Clicked on delete, on row ${workspace.name}`);
setSelectedWorkspace(workspace);
setActiveActionType(ActionType.Delete);
}, []);

const startRestartAction = React.useCallback((workspace: Workspace) => {
console.log(`Clicked on start/restart, on row ${workspace.name}`);
const startRestartAction = React.useCallback((workspace: Workspace, action: ActionType) => {
setSelectedWorkspace(workspace);
setActiveActionType(action);
setIsActionAlertModalOpen(true);
}, []);

const stopAction = React.useCallback((workspace: Workspace) => {
console.log(`Clicked on stop, on row ${workspace.name}`);
setSelectedWorkspace(workspace);
setActiveActionType(ActionType.Stop);
setIsActionAlertModalOpen(true);
}, []);

const handleDeleteClick = React.useCallback((workspace: Workspace) => {
Expand All @@ -322,35 +348,79 @@ export const Workspaces: React.FunctionComponent = () => {
setWorkspaceToDelete(workspace); // Open the modal and set workspace to delete
}, []);

const defaultActions = React.useCallback(
(workspace: Workspace): IActions =>
[
{
title: 'View Details',
onClick: () => selectWorkspace(workspace),
},
{
title: 'Edit',
onClick: () => editAction(workspace),
},
{
title: 'Delete',
onClick: () => handleDeleteClick(workspace),
},
{
isSeparator: true,
},
{
title: 'Start/restart',
onClick: () => startRestartAction(workspace),
},
{
title: 'Stop',
onClick: () => stopAction(workspace),
},
] as IActions,
[selectWorkspace, editAction, handleDeleteClick, startRestartAction, stopAction],
);
const onCloseActionAlertDialog = () => {
setIsActionAlertModalOpen(false);
setSelectedWorkspace(null);
setActiveActionType(null);
};

const workspaceDefaultActions = (workspace: Workspace): IActions => {
const workspaceState = workspace.status.state;
const workspaceActions = [
{
title: 'View Details',
onClick: () => viewDetailsClick(workspace),
},
{
title: 'Edit',
onClick: () => editAction(workspace),
},
{
title: 'Delete',
onClick: () => handleDeleteClick(workspace),
},
{
isSeparator: true,
},
workspaceState !== WorkspaceState.Running
? {
title: 'Start',
onClick: () => startRestartAction(workspace, ActionType.Start),
}
: {
title: 'Restart',
onClick: () => startRestartAction(workspace, ActionType.Restart),
},
] as IActions;

if (workspaceState === WorkspaceState.Running) {
workspaceActions.push({
title: 'Stop',
onClick: () => stopAction(workspace),
});
}
return workspaceActions;
};

const chooseAlertModal = () => {
switch (activeActionType) {
case ActionType.Start:
return (
<WorkspaceStartActionModal
onClose={onCloseActionAlertDialog}
isOpen={isActionAlertModalOpen}
workspace={selectedWorkspace}
/>
);
case ActionType.Restart:
return (
<WorkspaceRestartActionModal
onClose={onCloseActionAlertDialog}
isOpen={isActionAlertModalOpen}
workspace={selectedWorkspace}
/>
);
case ActionType.Stop:
return (
<WorkspaceStopActionModal
onClose={onCloseActionAlertDialog}
isOpen={isActionAlertModalOpen}
workspace={selectedWorkspace}
/>
);
}
return undefined;
};

// States

Expand Down Expand Up @@ -401,7 +471,10 @@ export const Workspaces: React.FunctionComponent = () => {
);

return (
<Drawer isInline isExpanded={selectedWorkspace != null}>
<Drawer
isInline
isExpanded={selectedWorkspace != null && activeActionType === ActionType.ViewDetails}
>
<DrawerContent panelContent={workspaceDetailsContent}>
<DrawerContentBody>
<PageSection isFilled>
Expand Down Expand Up @@ -483,7 +556,7 @@ export const Workspaces: React.FunctionComponent = () => {
</Td>
<Td isActionCell data-testid="action-column">
<ActionsColumn
items={defaultActions(workspace).map((action) => ({
items={workspaceDefaultActions(workspace).map((action) => ({
...action,
'data-testid': `action-${typeof action.title === 'string' ? action.title.toLowerCase() : ''}`,
}))}
Expand All @@ -496,6 +569,7 @@ export const Workspaces: React.FunctionComponent = () => {
</Tbody>
))}
</Table>
{isActionAlertModalOpen && chooseAlertModal()}
<DeleteModal
isOpen={workspaceToDelete != null}
resourceName={workspaceToDelete?.name || ''}
Expand Down
Loading