Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): client autogen to include verify_ssl param #764

Conversation

Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Feb 5, 2025

Description

Given that the verify_ssl code change was made on generated code, if local users try to run make build, the change gets overwritten and the client fails with this error:

TypeError: Configuration.__init__() got an unexpected keyword argument 'verify_ssl'

This PR aims to add the change to the configuration file template so that it gets into the autogenerated code.

How Has This Been Tested?

tested locally both manually and with e2e python tests

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

@tarilabs
Copy link
Member

tarilabs commented Feb 6, 2025

@lugi0 can you kindly check using this, your original intent is still covered, please?

@lugi0
Copy link
Contributor

lugi0 commented Feb 6, 2025

Tested make install with this change applied on top and working as it should, ty @Al-Pragliola

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much @Al-Pragliola , this makes it consistent with the approach to overcome analogous limitations of the openapi-codegen from the Go side

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lugi0, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0d47ddb into kubeflow:main Feb 6, 2025
15 checks passed
@Al-Pragliola Al-Pragliola deleted the al-pragliola-fix-verify-ssl-autogen branch February 6, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants