Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/kserve/kserve from 0.13.1 to 0.14.0 in /csi #493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 21, 2024

Bumps github.com/kserve/kserve from 0.13.1 to 0.14.0.

Release notes

Sourced from github.com/kserve/kserve's releases.

v0.14.0

What's Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 21, 2024
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ckadner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Member

This seems to me would make a requirement, at least for CSI, to bump to Go 1.22.

Is this worthy, or should we consider sticking to kserve api 0.13 for now, wdyt @Al-Pragliola @lampajr ?

@dependabot dependabot bot force-pushed the dependabot/go_modules/csi/github.com/kserve/kserve-0.14.0 branch from ed43804 to ce13868 Compare October 22, 2024 10:14
Bumps [github.com/kserve/kserve](https://github.com/kserve/kserve) from 0.13.1 to 0.14.0.
- [Release notes](https://github.com/kserve/kserve/releases)
- [Commits](kserve/kserve@v0.13.1...v0.14.0)

---
updated-dependencies:
- dependency-name: github.com/kserve/kserve
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/csi/github.com/kserve/kserve-0.14.0 branch from ce13868 to 24cfb98 Compare October 22, 2024 10:15
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to me would make a requirement, at least for CSI, to bump to Go 1.22.

+1 if we upgrade to kserve 0.14 we MUST update go to 1.22

Is this worthy, or should we consider sticking to kserve api 0.13 for now, wdyt @Al-Pragliola @lampajr ?

Technically the CSI is using kserve just for the model download, i.e., this package https://github.com/kserve/kserve/tree/37be2411b462687026686abac8d7bdb7c79c9cd2/pkg/agent/storage and there is just one diff between 0.13.1 and 0.14.0 (just one import change in the util.go) - therefore I don't think we have to upgrade kserve at the moment as there is no valid reason to do that (especially if we need to upgrade go).

@tarilabs
Copy link
Member

therefore I don't think we have to upgrade kserve at the moment as there is no valid reason to do that (especially if we need to upgrade go)

thanks for the confirmation 👍

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/CSI dependencies Pull requests that update a dependency file do-not-merge/hold go Pull requests that update Go code size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants