-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up staticcheck linter for BFF #378
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
58084a1
to
8aa4d94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me and thanks for the cleanup! Just want to double check that with Matteo!
@@ -24,6 +24,11 @@ jobs: | |||
working-directory: clients/ui/bff | |||
run: make clean | |||
|
|||
- uses: dominikh/staticcheck-action@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarilabs is there a policy to add third part actions on kubeflow?
/lgtm |
@lucferbux: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Griffin-Sullivan this will need a rebase. |
8aa4d94
to
e2ae96b
Compare
e2ae96b
to
35912ea
Compare
Signed-off-by: Griffin-Sullivan <[email protected]>
35912ea
to
444a12d
Compare
I've decided to use a different linting tool for the BFF so I'm going to close this and open another. |
Description
Linting the BFF folder with staticcheck and adding a step to run the linter in the BFF GitHub Action.
How Has This Been Tested?
Make sure the action passes and tests pass.
Merge criteria:
DCO
check)If you have UI changes