Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: provide py dist as gh artifact #352

Merged

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Sep 5, 2024

Description

Hopefully ease out local testing, without having to wait for a release for the py whl.

For more information, reference the github documentation.

How Has This Been Tested?

n/a

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@tarilabs
Copy link
Member Author

tarilabs commented Sep 5, 2024

Copy link
Contributor

@isinyaaa isinyaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

Signed-off-by: Matteo Mortari <[email protected]>
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Sep 6, 2024
@tarilabs
Copy link
Member Author

tarilabs commented Sep 6, 2024

I've evaluated the potential of using an ad-hoc session with fee9326
but I'm not very happy with this translating into its own GH runner.

@google-oss-prow google-oss-prow bot added size/XS and removed size/S labels Sep 6, 2024
@tarilabs
Copy link
Member Author

tarilabs commented Sep 6, 2024

So I'm binding this to the

matrix.session == 'tests' && matrix.python == '3.12'

To avoid defining a new session and GHA runner just for having an archive of the dist

Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isinyaaa, rareddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2b1ad4b into kubeflow:main Sep 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants