Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/kubeflow/model-registry from 0.2.4-alpha to 0.2.5-alpha in /clients/ui/bff #330

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 2, 2024

Bumps github.com/kubeflow/model-registry from 0.2.4-alpha to 0.2.5-alpha.

Release notes

Sourced from github.com/kubeflow/model-registry's releases.

v0.2.5-alpha

What's Changed

... (truncated)

Commits
  • d231290 chore: fix go .mod and .sum for CSI (#312)
  • 03296f9 build(deps-dev): bump @​testing-library/react from 14.3.1 to 16.0.0 in /client...
  • 75da03b build(deps-dev): bump react-router-dom from 6.26.0 to 6.26.1 in /clients/ui/f...
  • f525d98 build(deps-dev): bump ts-jest from 29.2.4 to 29.2.5 in /clients/ui/frontend (...
  • 4670a64 build(deps-dev): bump tslib from 2.6.3 to 2.7.0 in /clients/ui/frontend (#300)
  • 9127a0e build(deps-dev): bump css-minimizer-webpack-plugin from 5.0.1 to 7.0.0 in /cl...
  • abed26a Add app context and revamps App.tsx (#289)
  • 03ff357 build(deps): bump github.com/testcontainers/testcontainers-go from 0.32.0 to ...
  • 3be8f0a build(deps): bump huggingface-hub from 0.24.5 to 0.24.6 in /clients/python (#...
  • a11faa4 build(deps-dev): bump mypy from 1.11.1 to 1.11.2 in /clients/python (#308)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 2, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/clients/ui/bff/github.com/kubeflow/model-registry-0.2.5-alpha branch from 65cf89a to 47ed391 Compare September 2, 2024 12:38
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ederign. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dependabot dependabot bot force-pushed the dependabot/go_modules/clients/ui/bff/github.com/kubeflow/model-registry-0.2.5-alpha branch from 47ed391 to 440e70b Compare September 2, 2024 12:39
Bumps [github.com/kubeflow/model-registry](https://github.com/kubeflow/model-registry) from 0.2.4-alpha to 0.2.5-alpha.
- [Release notes](https://github.com/kubeflow/model-registry/releases)
- [Commits](v0.2.4-alpha...v0.2.5-alpha)

---
updated-dependencies:
- dependency-name: github.com/kubeflow/model-registry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/clients/ui/bff/github.com/kubeflow/model-registry-0.2.5-alpha branch from 440e70b to f06d133 Compare September 2, 2024 13:11
@ederign
Copy link
Member

ederign commented Sep 3, 2024

@tarilabs, there is a change on RegisteredModel Name property from the open API type generated from 0.24-alpha to 0.25-alpha:

From:

type RegisteredModel struct {
	// User provided custom properties which are not defined by its type.
	CustomProperties *map[string]MetadataValue `json:"customProperties,omitempty"`
	// An optional description about the resource.
	Description *string `json:"description,omitempty"`
	// The external id that come from the clients’ system. This field is optional. If set, it must be unique among all resources within a database instance.
	ExternalId *string `json:"externalId,omitempty"`
	// The client provided name of the artifact. This field is optional. If set, it must be unique among all the artifacts of the same artifact type within a database instance and cannot be changed once set.
	Name *string `json:"name,omitempty"`
	// Output only. The unique server generated id of the resource.
	Id *string `json:"id,omitempty"`
	// Output only. Create time of the resource in millisecond since epoch.
	CreateTimeSinceEpoch *string `json:"createTimeSinceEpoch,omitempty"`
	// Output only. Last update time of the resource since epoch in millisecond since epoch.
	LastUpdateTimeSinceEpoch *string               `json:"lastUpdateTimeSinceEpoch,omitempty"`
	Owner                    *string               `json:"owner,omitempty"`
	State                    *RegisteredModelState `json:"state,omitempty"`
}

To:

type RegisteredModel struct {
	// User provided custom properties which are not defined by its type.
	CustomProperties *map[string]MetadataValue `json:"customProperties,omitempty"`
	// An optional description about the resource.
	Description *string `json:"description,omitempty"`
	// The external id that come from the clients’ system. This field is optional. If set, it must be unique among all resources within a database instance.
	ExternalId *string `json:"externalId,omitempty"`
	// The client provided name of the artifact. This field is optional. If set, it must be unique among all the artifacts of the same artifact type within a database instance and cannot be changed once set.
	Name string `json:"name"`
	// Output only. The unique server generated id of the resource.
	Id *string `json:"id,omitempty"`
	// Output only. Create time of the resource in millisecond since epoch.
	CreateTimeSinceEpoch *string `json:"createTimeSinceEpoch,omitempty"`
	// Output only. Last update time of the resource since epoch in millisecond since epoch.
	LastUpdateTimeSinceEpoch *string               `json:"lastUpdateTimeSinceEpoch,omitempty"`
	Owner                    *string               `json:"owner,omitempty"`
	State                    *RegisteredModelState `json:"state,omitempty"`
}

I want to double-check that this is intentional on your side! Thanks!

@tarilabs
Copy link
Member

tarilabs commented Sep 3, 2024

@tarilabs, there is a change on RegisteredModel Name property from the open API type generated from 0.24-alpha to 0.25-alpha:

intentional, fixed in:

by @isinyaaa

@ederign
Copy link
Member

ederign commented Sep 3, 2024

Fixed by #342

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 5, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/clients/ui/bff/github.com/kubeflow/model-registry-0.2.5-alpha branch September 5, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants