-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kserve install instrunctions #2192
Add kserve install instrunctions #2192
Conversation
Hi @kairos03. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
@kairos03: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/assign @elikatsis |
/assign yanniszark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be really helpful for the community. Having just this comment in the yaml file, doesn't help much :
# For KF 1.5 we are including both KFServing and KServe. Thus we install the
# standalone kserve manifests, to avoid conflicts with 0.6.1 KFServing.
Thanks @kairos03 for contributing this.
Co-authored-by: rachitchauhan43 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kairos03 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for your comment. I reflect your commit. :) and plz agree CLA. @rachitchauhan43 |
Agreed to CLA. |
@kimwnasptd could you see this PR? Other reviewer seems not active TT |
/assign @kimwnasptd |
Please put this on the agenda of the next manifest wg meeting in two weeks and join us for a discussion |
/close |
@juliusvonkohout: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Which issue is resolved by this Pull Request:
Resolves #2178
Description of your changes:
Add Kserve install instructions for integrate with kubeflow without KFServing.
Checklist:
Make sure you have installed kustomize == 3.2.1
make generate-changed-only
make test