Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kserve install instrunctions #2192

Conversation

kairos03
Copy link

@kairos03 kairos03 commented Apr 25, 2022

Which issue is resolved by this Pull Request:
Resolves #2178

Description of your changes:
Add Kserve install instructions for integrate with kubeflow without KFServing.

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

@aws-kf-ci-bot
Copy link

Hi @kairos03. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kairos03
Copy link
Author

/test all

@aws-kf-ci-bot
Copy link

@kairos03: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@kairos03
Copy link
Author

/assign @elikatsis

@kairos03
Copy link
Author

/assign yanniszark

Copy link

@rachitchauhan43 rachitchauhan43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be really helpful for the community. Having just this comment in the yaml file, doesn't help much :

# For KF 1.5 we are including both KFServing and KServe. Thus we install the
# standalone kserve manifests, to avoid conflicts with 0.6.1 KFServing.

Thanks @kairos03 for contributing this.

README.md Outdated Show resolved Hide resolved
Co-authored-by: rachitchauhan43 <[email protected]>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kairos03
To complete the pull request process, please ask for approval from elikatsis after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kairos03
Copy link
Author

kairos03 commented Jun 9, 2022

This will be really helpful for the community. Having just this comment in the yaml file, doesn't help much :

# For KF 1.5 we are including both KFServing and KServe. Thus we install the
# standalone kserve manifests, to avoid conflicts with 0.6.1 KFServing.

Thanks @kairos03 for contributing this.

Thank you for your comment. I reflect your commit. :) and plz agree CLA. @rachitchauhan43

@kairos03 kairos03 requested a review from Arhell June 9, 2022 03:57
@rachitchauhan43
Copy link

This will be really helpful for the community. Having just this comment in the yaml file, doesn't help much :

# For KF 1.5 we are including both KFServing and KServe. Thus we install the
# standalone kserve manifests, to avoid conflicts with 0.6.1 KFServing.

Thanks @kairos03 for contributing this.

Thank you for your comment. I reflect your commit. :) and plz agree CLA. @rachitchauhan43

Agreed to CLA.

@kairos03
Copy link
Author

kairos03 commented Jun 9, 2022

@kimwnasptd could you see this PR? Other reviewer seems not active TT

@kairos03
Copy link
Author

kairos03 commented Jun 9, 2022

/assign @kimwnasptd

@juliusvonkohout
Copy link
Member

Please put this on the agenda of the next manifest wg meeting in two weeks and join us for a discussion

@juliusvonkohout
Copy link
Member

/close

@google-oss-prow google-oss-prow bot closed this Nov 29, 2023
Copy link

@juliusvonkohout: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kserve is not installed with Kubeflow 1.5
8 participants