kserve: Add distinct file for cluster-roles #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When we install both KFServing 0.6.1 and KServe 0.7.0 we are using the
standalone version of KServe 0.7.0. But, the standalone KServe
installation does not include the aggregated roles for the KF
kubeflow-{admin,editor,viewer} roles.
This commit adds the needed clusterroles/bingings as a distinct file to
explicitly include them, when installing both KFServing and standalone
KServe.
Signed-off-by: Kimonas Sotirchos <[email protected]>
In order to use the KServe MWA by default we will need to use the kubeflow overlay. This overlay updates the VirtualService to use the kubeflow/kubeflow-gateway Gateway, alongside the other KF apps. Signed-off-by: Kimonas Sotirchos <[email protected]>
kimwnasptd
force-pushed
the
feature-kimwnasptd-kserve-kf-roles
branch
from
c2f4fcd
to
0a5d72c
Compare
|
/lgtm |
kimwnasptd
added a commit
that referenced
this pull request
Mar 4, 2022
* kserve: Add distinct file for cluster-roles
When we install both KFServing 0.6.1 and KServe 0.7.0 we are using the
standalone version of KServe 0.7.0. But, the standalone KServe
installation does not include the aggregated roles for the KF
kubeflow-{admin,editor,viewer} roles.
This commit adds the needed clusterroles/bingings as a distinct file to
explicitly include them, when installing both KFServing and standalone
KServe.
Signed-off-by: Kimonas Sotirchos <[email protected]>
* kserve: Use kubeflow overlay of MWA
In order to use the KServe MWA by default we will need to use the
kubeflow overlay. This overlay updates the VirtualService to use the
kubeflow/kubeflow-gateway Gateway, alongside the other KF apps.
Signed-off-by: Kimonas Sotirchos <[email protected]>
Closed
kevin85421
pushed a commit
to juliusvonkohout/manifests
that referenced
this pull request
Feb 28, 2023
* kserve: Add distinct file for cluster-roles
When we install both KFServing 0.6.1 and KServe 0.7.0 we are using the
standalone version of KServe 0.7.0. But, the standalone KServe
installation does not include the aggregated roles for the KF
kubeflow-{admin,editor,viewer} roles.
This commit adds the needed clusterroles/bingings as a distinct file to
explicitly include them, when installing both KFServing and standalone
KServe.
Signed-off-by: Kimonas Sotirchos <[email protected]>
* kserve: Use kubeflow overlay of MWA
In order to use the KServe MWA by default we will need to use the
kubeflow overlay. This overlay updates the VirtualService to use the
kubeflow/kubeflow-gateway Gateway, alongside the other KF apps.
Signed-off-by: Kimonas Sotirchos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we install both KFServing 0.6.1 and KServe 0.7.0 we are using the standalone version of KServe 0.7.0. But, the standalone KServe installation does not include the aggregated roles for the KF
kubeflow-{admin,editor,viewer}roles.This PR adds the needed clusterroles/bingings as a distinct file to explicitly include them, when installing both KFServing and standalone KServe.
This should be removed within the next release.
Depends on:
cc @kubeflow/release-team