-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improved membership request template #737
Conversation
Hi @dandawg. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@dandawg: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d9269b8
to
029a107
Compare
Signed-off-by: Daniel Dowler <[email protected]>
029a107
to
2a8731f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR improves the instructions on the membership request template, fixing in particular the formatting and instructions on submitting a PR.
The issue was that the flow for becoming a Kubeflow member (as outlined here) call for creating an issue. The issue template then mentions "Please test your PR". This is confusing because you haven't created a PR yet at this point.
In addition, there are no easily findable instructions stating that you need to "modify the
org.yaml
in thegithub-orgs/kubeflow
directory. I had to search around the source code to find them when I was becoming a member.This PR makes the process easier by formatting the membership request template, and by including more detailed instructions on what is required in the PR.