Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved membership request template #737

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

dandawg
Copy link
Contributor

@dandawg dandawg commented Jan 24, 2025

This PR improves the instructions on the membership request template, fixing in particular the formatting and instructions on submitting a PR.

The issue was that the flow for becoming a Kubeflow member (as outlined here) call for creating an issue. The issue template then mentions "Please test your PR". This is confusing because you haven't created a PR yet at this point.

In addition, there are no easily findable instructions stating that you need to "modify the org.yaml in the github-orgs/kubeflow directory. I had to search around the source code to find them when I was becoming a member.

This PR makes the process easier by formatting the membership request template, and by including more detailed instructions on what is required in the PR.

Copy link

Hi @dandawg. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dandawg
Copy link
Contributor Author

dandawg commented Jan 30, 2025

/ok-to-test

Copy link

@dandawg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan terrytangyuan merged commit afca8b5 into kubeflow:master Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants