Add customized mapper #105
Conversation
Signed-off-by: QiQi-OvO <[email protected]> add customized mapper Signed-off-by: QiQi-OvO <[email protected]> fix some bugs Signed-off-by: QiQi-OvO <[email protected]>
Signed-off-by: QiQi-OvO <[email protected]>
| @@ -48,6 +48,7 @@ func main() { | |||
| SockPath: c.GrpcServer.SocketPath, | |||
| Protocol: common.ProtocolModbus, | |||
| }, | |||
| device.NewDevPanel(), | |||
There was a problem hiding this comment.
The parameters of the NewServer function have been changed, because of this change can simplify the code and enable compatibility with more devices without importing corresponding device packages.
There was a problem hiding this comment.
Sorry, I missed it earlier. This is a nice change!
There was a problem hiding this comment.
I tried to reproduce this virtualdevice-dmi example, but the following problem occurred
I0831 21:38:19.609843 659379 device.go:114] visitorConfig: {ProtocolName:virtualProtocol VisitorConfigData:{DataType:}}
I0831 21:38:19.609916 659379 device.go:150] random-instance-01 twin readonly property: random-float
E0831 21:38:20.610317 659379 twindata.go:59] twindata random-float unmarshal failed, err: get device data failed: unrecognized data type
There was a problem hiding this comment.
This seems to be an issue with parsing CRD, are you using mappers/virtualdevice-dmi/resource/random-device-instance.yaml and mappers/virtualdevice-dmi/resource/random-device-model.yaml from PR?
And there is a bug in the DMI code of the current EdgeCore that cannot resolve the customized field. Please refer to this PR.
If you want to know what went wrong during the parsing process, you can unmarshal the value of the visitor to the map[string]interface{} and print it.
pkg/grpcserver/device.go
Outdated
| @@ -176,6 +178,19 @@ func (s *Server) GetDevice(ctx context.Context, request *dmiapi.GetDeviceRequest | |||
| } | |||
| res.Device.Status.Twins = twins | |||
| res.Device.Status.State = common.DEVSTOK | |||
| case common.ProtocolCustomized: | |||
| deviceValue := reflect.ValueOf(device) | |||
| //d := device.(*customizedDriver.CustomizedDev) | |||
There was a problem hiding this comment.
Is it possible to remove it?
There was a problem hiding this comment.
To make this a universal framework. I plan to delete all switch/case structures and not import the corresponding device's packages, and subsequently obtain the corresponding fields through reflection. I will modify it later and hope you can continue to provide valuable feedback. Thanks! :)
There was a problem hiding this comment.
sorry, but I mean //d := device.(*customizedDriver.CustomizedDev) this unused code, Is it possible to remove it?
Signed-off-by: QiQi-OvO <[email protected]>
kubeedge-bot
added
the
needs-rebase
|
@QiQi-OvO: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Now, we can use
make dmitemplateto get a dmi template. And provided a example to help developers start their work.Which issue(s) this PR fixes:
Implemented one feature in kubeedge/kubeedge#4744
Special notes for your reviewer:
You can find more details in exmaple.