host network promoted to spec field #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Basit Hasan <[email protected]>
SimonCqk
reviewed
Nov 24, 2023
| ) | ||
|
|
||
| func EnableHostNetwork(job metav1.Object) bool { | ||
| return job.GetAnnotations()[v1.AnnotationNetworkMode] == string(v1.HostNetworkMode) |
There was a problem hiding this comment.
should we consider backward compatibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Host network annotation elevated to spec field
II. Does this pull request fix one issue?
fixes #260
III. Special notes for reviewers if any.
Test files is not updated yet!