when cloud costs is not enabled, don't deploy it #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that this is the right design, but the frontend would need an update to prevent the user from adding a cloud integration and instruct them on the best practices? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
changes the scope of the if cloud costs enabled control statement to avoid rendering the cloud costs deployment (thereby installing it), when cloud costs is disabled
Does this PR rely on any other PRs?
no
How does this PR impact users? (This is the kind of thing that goes in release notes!)
should allow them to not deploy cloud costs if they don't want to
What risks are associated with merging this PR? What is required to fully test this PR?
Low risk
How was this PR tested?
tested via argo install on clickhouse demo env
Have you made an update to documentation? If so, please provide the corresponding PR.