Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional creation of ConfigMap for cm.data in kube-vip-cloud-p… #39

Merged

Conversation

ibra-coul
Copy link
Contributor

…rovider Helm chart

…rovider Helm chart

Signed-off-by: Ibrahima COULIBALY <[email protected]>
@ibra-coul ibra-coul force-pushed the feature/configmap-implementation branch from 9e595c2 to 79e732e Compare July 23, 2024 13:40
@thebsdbox thebsdbox merged commit f93c33a into kube-vip:main Oct 3, 2024
1 check passed
@rptaylor
Copy link
Contributor

How does KVCP find the right configmap to use?
Looks like the helm chart needs to configure some environment variables too?
kube-vip/kube-vip-cloud-provider#63

@ibra-coul
Copy link
Contributor Author

@rptaylor I have added the environment variables KUBEVIP_NAMESPACE and KUBEVIP_CONFIG_MAP #48 which is waiting to merge. It is imperative to deploy kube-vip-cloud-provider in the kube-system namespace. I opened the issue #47 about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants