Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix misleading extra error generated from cluster-agent #77

Merged
merged 1 commit into from
May 2, 2024

Conversation

andylibrian
Copy link
Collaborator

No description provided.

@andylibrian andylibrian self-assigned this Mar 24, 2024
@andylibrian andylibrian marked this pull request as ready for review March 24, 2024 02:11
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@631249e). Click here to learn what that means.

❗ Current head e8ecf89 differs from pull request most recent head 72a8d51. Consider uploading reports for the commit 72a8d51 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage        ?   72.36%           
=======================================
  Files           ?       35           
  Lines           ?     2095           
  Branches        ?        0           
=======================================
  Hits            ?     1516           
  Misses          ?      485           
  Partials        ?       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andylibrian andylibrian force-pushed the fix-cluster-agent-extra-error-msg branch 2 times, most recently from 6f00d86 to e8ecf89 Compare March 24, 2024 02:28
kumari-anupam
kumari-anupam previously approved these changes May 1, 2024
Copy link
Collaborator

@kumari-anupam kumari-anupam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andylibrian andylibrian force-pushed the fix-cluster-agent-extra-error-msg branch from e8ecf89 to 72a8d51 Compare May 2, 2024 07:23
@andylibrian andylibrian merged commit 130e7ce into main May 2, 2024
20 checks passed
@andylibrian andylibrian deleted the fix-cluster-agent-extra-error-msg branch May 2, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants