-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: add unit tests and add code coverage
- Loading branch information
1 parent
f8a98bf
commit a85a8e4
Showing
28 changed files
with
1,035 additions
and
122 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,4 @@ | |
| /pkg/**/capture_exec.bpf.o | ||
| /pkg/tarianpb/api.pb.go | ||
| /pkg/tarianpb/types.pb.go | ||
| coverage.xml | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,232 @@ | ||
| package add | ||
|
|
||
| import ( | ||
| "net" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/kube-tarian/tarian/cmd/tarianctl/cmd/flags" | ||
| ugrpc "github.com/kube-tarian/tarian/cmd/tarianctl/util/grpc" | ||
| "github.com/kube-tarian/tarian/pkg/log" | ||
| "github.com/spf13/cobra" | ||
| "github.com/stretchr/testify/assert" | ||
| "google.golang.org/grpc" | ||
| ) | ||
|
|
||
| func TestActionCommand_Run(t *testing.T) { | ||
| // t.Parallel() | ||
| tests := []struct { | ||
| name string | ||
| expectedErr string | ||
| expectedLog string | ||
|
|
||
| grpcClient ugrpc.Client | ||
| dryRun bool | ||
| onViolatedFile bool | ||
| onViolatedProcess bool | ||
| matchLabels []string | ||
| action string | ||
| onFalcoAlert string | ||
| }{ | ||
| { | ||
| name: "Add Action Successfully", | ||
| grpcClient: ugrpc.NewFakeGrpcClient(), | ||
| action: "delete-pod", | ||
| expectedLog: "Action was added successfully", | ||
| }, | ||
| { | ||
| name: "Add Action with Dry Run", | ||
| grpcClient: ugrpc.NewFakeGrpcClient(), | ||
| dryRun: true, | ||
| action: "delete-pod", | ||
| matchLabels: []string{ | ||
| "key1=val1", | ||
| "key2=val2", | ||
| }, | ||
| expectedLog: `kind: Action | ||
| namespace: test-namespace | ||
| name: test-action | ||
| selector: | ||
| matchlabels: | ||
| - key: key1 | ||
| value: val1 | ||
| - key: key2 | ||
| value: val2 | ||
| onviolatedprocess: false | ||
| onviolatedfile: false | ||
| onfalcoalert: false | ||
| falcopriority: 0 | ||
| action: delete-pod | ||
| `, | ||
| }, | ||
| { | ||
| name: "Add Action with Dry Run and On Falco Alert", | ||
| grpcClient: ugrpc.NewFakeGrpcClient(), | ||
| dryRun: true, | ||
| action: "delete-pod", | ||
| onFalcoAlert: "alert", | ||
| expectedLog: `kind: Action | ||
| namespace: test-namespace | ||
| name: test-action | ||
| selector: | ||
| matchlabels: [] | ||
| onviolatedprocess: false | ||
| onviolatedfile: false | ||
| onfalcoalert: true | ||
| falcopriority: 1 | ||
| action: delete-pod | ||
| `, | ||
| }, | ||
| { | ||
| name: "Add Action with Invalid Falco Alert", | ||
| grpcClient: ugrpc.NewFakeGrpcClient(), | ||
| action: "delete-pod", | ||
| onFalcoAlert: "invalid", | ||
| expectedErr: "add action: invalid falco alert: invalid", | ||
| }, | ||
| { | ||
| name: "Add Action on Violated Process and violated file", | ||
| grpcClient: ugrpc.NewFakeGrpcClient(), | ||
| dryRun: true, | ||
| action: "delete-pod", | ||
| onViolatedFile: true, | ||
| onViolatedProcess: true, | ||
| expectedLog: `kind: Action | ||
| namespace: test-namespace | ||
| name: test-action | ||
| selector: | ||
| matchlabels: [] | ||
| onviolatedprocess: true | ||
| onviolatedfile: true | ||
| onfalcoalert: false | ||
| falcopriority: 0 | ||
| action: delete-pod | ||
| `, | ||
| }, | ||
| { | ||
| name: "Add Action with Invalid Action", | ||
| grpcClient: ugrpc.NewFakeGrpcClient(), | ||
| action: "invalid", | ||
| expectedErr: "invalid action: invalid", | ||
| }, | ||
| { | ||
| name: "Use real gRPC client", | ||
| action: "delete-pod", | ||
| expectedErr: "rpc error: code = Unimplemented desc = unknown service tarianpb.api.Config", | ||
| }, | ||
| } | ||
|
|
||
| serverAddr := "localhost:50051" | ||
| go startFakeServer(t, serverAddr) | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| // Create the action command with the test configuration | ||
| cmd := &actionCommand{ | ||
| globalFlags: &flags.GlobalFlags{ | ||
| ServerAddr: serverAddr, | ||
| }, | ||
| logger: log.GetLogger(), | ||
| grpcClient: tt.grpcClient, | ||
| dryRun: tt.dryRun, | ||
| onFalcoAlert: tt.onFalcoAlert, | ||
| onViolatedProcess: tt.onViolatedProcess, | ||
| onViolatedFile: tt.onViolatedFile, | ||
| action: tt.action, | ||
| name: "test-action", | ||
| namespace: "test-namespace", | ||
| matchLabels: tt.matchLabels, | ||
| } | ||
|
|
||
| // Capture log output | ||
| logOutput := []byte{} | ||
| cmd.logger.Out = &logOutputWriter{&logOutput} | ||
|
|
||
| // Call the run function | ||
| err := cmd.run(nil, nil) | ||
|
|
||
| // Assert expected error, if any | ||
| if tt.expectedErr != "" { | ||
| assert.Contains(t, err.Error(), tt.expectedErr) | ||
| } else { | ||
| if !assert.NoError(t, err) { | ||
| assert.FailNow(t, "error not expected") | ||
| } | ||
| } | ||
|
|
||
| // Assert expected log output | ||
| if tt.expectedLog != "" { | ||
| assert.Equal(t, strings.TrimSpace(cleanLog(string(logOutput))), strings.TrimSpace(tt.expectedLog)) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| // Helper struct to capture log output | ||
| type logOutputWriter struct { | ||
| output *[]byte | ||
| } | ||
|
|
||
| func (w *logOutputWriter) Write(p []byte) (n int, err error) { | ||
| *w.output = append(*w.output, p...) | ||
| return len(p), nil | ||
| } | ||
|
|
||
| func startFakeServer(t *testing.T, serverAddr string) { | ||
| lis, err := net.Listen("tcp", serverAddr) | ||
| if err != nil { | ||
| assert.NoError(t, err) | ||
| } | ||
|
|
||
| srv := grpc.NewServer() | ||
|
|
||
| if err := srv.Serve(lis); err != nil { | ||
| assert.NoError(t, err) | ||
| } | ||
| } | ||
|
|
||
| func cleanLog(logLine string) string { | ||
| index := strings.Index(logLine, "]") | ||
| return logLine[index+2:] | ||
| } | ||
|
|
||
| func TestNewAddActionCommand(t *testing.T) { | ||
| // Create a mock globalFlags instance | ||
| mockGlobalFlags := &flags.GlobalFlags{ | ||
| ServerAddr: "mock-server-address", | ||
| // Add other fields as needed | ||
| } | ||
|
|
||
| // Call the function to be tested | ||
| cmd := newAddActionCommand(mockGlobalFlags) | ||
|
|
||
| // Check if the returned value is of type *cobra.Command | ||
| assert.IsType(t, &cobra.Command{}, cmd) | ||
|
|
||
| // Check if specific flags are correctly added | ||
| namespaceFlag := cmd.Flags().Lookup("namespace") | ||
| assert.NotNil(t, namespaceFlag) | ||
| assert.Equal(t, "default", namespaceFlag.DefValue) // Check default value | ||
|
|
||
| nameFlag := cmd.Flags().Lookup("name") | ||
| assert.NotNil(t, nameFlag) | ||
|
|
||
| matchLabelsFlag := cmd.Flags().Lookup("match-labels") | ||
| assert.NotNil(t, matchLabelsFlag) | ||
|
|
||
| actionFlag := cmd.Flags().Lookup("action") | ||
| assert.NotNil(t, actionFlag) | ||
|
|
||
| dryRunFlag := cmd.Flags().Lookup("dry-run") | ||
| assert.NotNil(t, dryRunFlag) | ||
|
|
||
| onViolatedProcessFlag := cmd.Flags().Lookup("on-violated-process") | ||
| assert.NotNil(t, onViolatedProcessFlag) | ||
|
|
||
| onViolatedFileFlag := cmd.Flags().Lookup("on-violated-file") | ||
| assert.NotNil(t, onViolatedFileFlag) | ||
|
|
||
| onFalcoAlertFlag := cmd.Flags().Lookup("on-falco-alert") | ||
| assert.NotNil(t, onFalcoAlertFlag) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.