Contributing.md and DCO #602
Conversation
clux
force-pushed
the
contrib-dco
branch
3 times, most recently
from
855aabf to
2918ba5
Compare
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
|
Ok, the DCO does take a bit of work for users the first time. The instructions for the last commit is clear: git commit --amend --signoff
git push -fbut if you have more than one commit you actually have to: git rebase --exec 'git commit --amend --no-edit -n --signoff' -i origin/master
git push -for squash first, then do the first solution. |
| @@ -187,7 +187,7 @@ | |||
| same "printed page" as the copyright notice for easier | |||
| identification within third-party archives. | |||
|
|
|||
| Copyright 2014 The Kubernetes Authors. | |||
| Copyright 2018 The kube-rs Authors. | |||
There was a problem hiding this comment.
| Copyright 2018 The kube-rs Authors. | |
| Copyright 2018-2021 The kube-rs Authors. |
There was a problem hiding this comment.
bumping years in copyright files isn't actually a legally viable nor necessary thing to do: https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-keep-the-year
There was a problem hiding this comment.
you could also go the client-go way
CONTRIBUTING.md
Outdated
| changes on that branch, and then use GitHub to open a pull request with your | ||
| changes. | ||
|
|
||
| Every PR must be reviewed by at least one Core Maintainer of the project. Once |
There was a problem hiding this comment.
Nit: Might be worth defining a list of Core Maintainers somewhere (codeowners file? org members?)
In the latter case, you're still listed as private over at https://github.com/orgs/kube-rs/people.
There was a problem hiding this comment.
I have updated my membership to public. That was an accident.
Also I have renamed the owners team to core-maintainers: https://github.com/orgs/kube-rs/teams/core-maintainers
I'll add a link to it.
There was a problem hiding this comment.
Doesn't look like the team is public, FWIW.
There was a problem hiding this comment.
It is set to visible, which is the highest setting. But apparently teams are only visible to org members, so may need to do something else there.
Signed-off-by: clux <[email protected]>
Based on simpler requirements and discussion after #585 (comment)