Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rand dependency in favor of tungstenite fn #1691

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Remove rand dependency in favor of tungstenite fn #1691

merged 1 commit into from
Feb 10, 2025

Conversation

clux
Copy link
Member

@clux clux commented Feb 9, 2025

Found tungstenite::handshake::client::generate_key which is blanket re-exported via tokio-tungstenite (which we already depend on under ws feature)

we still use rand as a dev dependency, but less explicit things on users, and less re-implementing the same logic.

@clux clux changed the title Get rid of rand dependency in favor of tungstenite builtin fn Remove rand dependency in favor of tungstenite fn Feb 9, 2025
@clux clux added the dependencies upgrades to dependencies label Feb 9, 2025
@clux clux marked this pull request as ready for review February 9, 2025 00:36
@clux clux added this to the 0.99.0 milestone Feb 9, 2025
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.8%. Comparing base (267c224) to head (a35dcc8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1691     +/-   ##
=======================================
- Coverage   75.8%   75.8%   -0.0%     
=======================================
  Files         84      84             
  Lines       7629    7626      -3     
=======================================
- Hits        5779    5776      -3     
  Misses      1850    1850             
Files with missing lines Coverage Δ
kube-client/src/client/mod.rs 75.8% <100.0%> (ø)
kube-client/src/client/upgrade.rs 75.0% <ø> (-3.2%) ⬇️

@clux clux added the changelog-change changelog change category for prs label Feb 10, 2025
@clux clux merged commit 07b7891 into main Feb 10, 2025
17 checks passed
@clux clux deleted the drop-rand branch February 10, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant