Skip to content

use rustls-pki-types pem api #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Feb 7, 2025

Uses rustls-pki-types pem api directly.

@tottoto tottoto force-pushed the use-rustls-pki-types-pem-api branch from 90faad4 to 06edcfa Compare February 7, 2025 21:16
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.8%. Comparing base (0bcc625) to head (c31d5ce).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kube-client/src/client/tls.rs 66.7% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1690     +/-   ##
=======================================
+ Coverage   75.8%   75.8%   +0.1%     
=======================================
  Files         84      84             
  Lines       7630    7629      -1     
=======================================
  Hits        5779    5779             
+ Misses      1851    1850      -1     
Files with missing lines Coverage Δ
kube-client/src/client/tls.rs 82.8% <66.7%> (+1.0%) ⬆️

@tottoto tottoto force-pushed the use-rustls-pki-types-pem-api branch 2 times, most recently from c13c8bb to 213f75a Compare February 7, 2025 21:45
@tottoto tottoto force-pushed the use-rustls-pki-types-pem-api branch from 213f75a to c31d5ce Compare February 7, 2025 21:59
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup of that explicit dependency. Thank you.

@clux clux added the changelog-exclude changelog excluded prs label Feb 8, 2025
@clux clux added this to the 0.99.0 milestone Feb 8, 2025
@clux clux added the dependencies upgrades to dependencies label Feb 8, 2025
@clux clux merged commit 267c224 into kube-rs:main Feb 8, 2025
17 checks passed
@tottoto tottoto deleted the use-rustls-pki-types-pem-api branch February 8, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants