Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable adding annotations and labels to pvcs #1827

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

csatib02
Copy link
Member

This PR enables adding labels and annotations to pvcs claimed by the fluentd STS.

Manually tested with the following manifest:

apiVersion: logging.banzaicloud.io/v1beta1
kind: Logging
metadata:
  name: all-to-file
spec:
  controlNamespace: default
  fluentd:
    bufferStorageVolume:
      pvc:
        labels:
          app: logging
        annotations:
          app: logging
        source:
          claimName: manual
          readOnly: false

STS:
kép

PVC:
kép

@csatib02 csatib02 added the enhancement New feature or request label Oct 11, 2024
@csatib02 csatib02 self-assigned this Oct 11, 2024
@csatib02 csatib02 linked an issue Oct 11, 2024 that may be closed by this pull request
go.mod Outdated Show resolved Hide resolved
@csatib02 csatib02 merged commit 835a4a9 into master Oct 11, 2024
19 checks passed
@csatib02 csatib02 deleted the feat/enable-adding-annotations-and-labels-to-pvcs branch October 11, 2024 14:52
@sebastiangaiser
Copy link
Contributor

TYVM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FluentD buffer pvc annotations and labels
4 participants