Subset of metadata fields #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsevilla87
commented
Sep 26, 2024
rsevilla87
force-pushed
the
minimal-metadata
branch
3 times, most recently
from
cbe6ed4
to
ef52eef
Compare
vishnuchalla
reviewed
Oct 8, 2024
go.mod
Outdated
| @@ -85,3 +85,5 @@ require ( | |||
| sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect | |||
| sigs.k8s.io/yaml v1.3.0 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/kube-burner/kube-burner => github.com/rsevilla87/kube-burner v1.7.6-0.20240926090502-2e59036445b9 | |||
There was a problem hiding this comment.
upstream is merged, will wait for this to be updated as well.
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87
force-pushed
the
minimal-metadata
branch
from
f809b13
to
28cd61e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Follow-up of kube-burner/kube-burner#702
As agreed with the team (cc @mukrishn), let's add a small subset of metadata fields to all metrics (ocpVersion and ocpMajorVersion) generated by kube-burner.
Related Tickets & Documents
Checklist before requesting a review