-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix check for blob should check for a file instead of a string #1400
Conversation
🦋 Changeset detectedLatest commit: ecba81c The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@all-contributors please add @ekaradon for code |
I've put up a pull request to add @ekaradon! 🎉 |
@ekaradon hmm I was not aware off that could use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just update the test cases, pnpm test -u
to update the snapshots
I'm not used to workspace, so I may have missed a step but when I try to run tests after installing with
Not sure what I should do to get it working? |
I've continued working with zod and got an error when using it to parse a response from the backend service where it tries to match a blob with a string. I suppose that
z.instanceOf(File)
would be the best approach here?KUBB-70 Zod generation is considering blob as a string
#1399