Improve Jetty connection configuration by exposing a builder on Jetty's HttpConfiguration object #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amccague
commented
Oct 9, 2024
Comment on lines
57
to
+58
| initializeServer(configuration) | ||
| configuration.configureServer(this) |
There was a problem hiding this comment.
Porting this change here #4367 to Jetty Jarkarta (I did not notice this update in the first instance)
amccague
force-pushed
the
configure_jetty_server_connection
branch
2 times, most recently
from
f831b02
to
2dd1a4a
Compare
…ttpConfiguration object
amccague
force-pushed
the
configure_jetty_server_connection
branch
from
2dd1a4a
to
a9dbb73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Jetty connection configuration by exposing a builder on Jetty's HttpConfiguration object
Would address the concern of https://youtrack.jetbrains.com/issue/KTOR-27/Increase-max-HTTP-header-size-for-server (which was closed as a duplicate for a Netty specific issue)
Subsystem
Jetty and Jetty Jarkarta Server
Motivation
Our particular use case was for configuring more header size on the Jetty Server from its default of 8KB.
Solution
Given the large number of options available on https://github.com/jetty/jetty.project/blob/ea258a362100ce21da02a960bee66dab745c4c99/jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/HttpConfiguration.java .
Rather than exposing this as a specific configuration, it felt more flexible to provide a builder on the
HttpConfigurationitself and apply that as part of Server Initialization.Additionally compared to the existing
configureServerapproach it enables modifying the connectors configured by the ktor framework with minimal mutation/intervention by the application developer.