-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTOR-6960 Add UnixDomainSocket support for iOS/tvOS/watchOS #4024
base: main
Are you sure you want to change the base?
Conversation
Hey @05nelsonm, thanks for the PR. Let me run a CI check |
I think unix sockets do not work on watchOS. Did you actually try this on a real watch instead of a simulator? See: https://developer.apple.com/documentation/technotes/tn3135-low-level-networking-on-watchos So I guess it is better to revert the changes for watchOS to avoid confusion for other users thinking Ktor supports it. |
@Thomas-Vos, it looks so, thank you for noticing! @05nelsonm, could you tell me if you have a chance to check? |
I tend not to believe apple's documentation over their header files which are all identical for each platform (device or simulator).
{PLATFORM}.sdk/usr/include/sys/un.h
I believe the failures are attributed to an error in the Will rebase and fix! |
Subsystem
Module
ktor-network
Motivation
https://youtrack.jetbrains.com/issue/KTOR-6960/Unix-Domain-Socket-Support-for-iOS-tvOS-watchOS
Solution
Adds cinterop definition to include
sys/un.h
headers for iOS/tvOS/watchOS giving access tosockaddr_un
struct for given SDKs, and implements pack/unpack sockaddr_un functions