-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports static linking for curl engine #3981
Open
dtretyakov
wants to merge
5
commits into
ktorio:main
Choose a base branch
from
dtretyakov:curl/static
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtretyakov
force-pushed
the
curl/static
branch
from
February 8, 2024 09:24
4729816
to
b153512
Compare
The following builds are failing: Static libcurl compilation Linux:
macOS:
Windows:
|
dtretyakov
force-pushed
the
curl/static
branch
6 times, most recently
from
February 25, 2024 19:13
3708fc2
to
332dcaf
Compare
dtretyakov
force-pushed
the
curl/static
branch
from
August 30, 2024 16:02
0b47bb3
to
90ecd0f
Compare
It allows us supporting linux/macOS/Windows targets.
dtretyakov
force-pushed
the
curl/static
branch
from
September 26, 2024 22:23
90ecd0f
to
b1224da
Compare
dtretyakov
force-pushed
the
curl/static
branch
from
September 26, 2024 23:04
b1224da
to
aabe717
Compare
e5l
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ld.lld: error: undefined symbol: explicit_bzero
@dtretyakov, could you check the build?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Client, curl engine
Motivation
We need a way to support consistent set of features across all native platforms. Fixes KTOR-6754
Solution
We're using scripts to update cinterop for the following platforms: