Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTOR-6182 Support throwing
UnknownServiceException
if there is no cleartext traffic permitted #3725base: main
Are you sure you want to change the base?
KTOR-6182 Support throwing
UnknownServiceException
if there is no cleartext traffic permitted #3725Changes from 2 commits
7d3fb01
1641149
f0733ef
ced616f
044d2b6
54df7e7
9ff3467
e8dd071
cb1e09c
ed199d2
e048727
140c37c
a4a1c11
4273c1e
93c5751
f32ce93
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These aren't the full story for OkHttp.
We compile against robolectric android-all in order to call these APIs directly.
https://github.com/square/okhttp/blob/okhttp_4x/okhttp/src/main/kotlin/okhttp3/internal/platform/AndroidPlatform.kt
It's way simpler than the reflection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I borrowed these code from the old implementation, cause I see there is no Android Runtime applied in CIO module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for OkHttp. It's a compile only dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very sure if we should put this check here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do it earlier, before creating connection. Maybe even in the
CIOEngine.execute
method. Also, don't you need to check that the traffic is clear text?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can, but I see this check had been seated at a simular position in Okhttp, not very sure why.
@yschimke Can you take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about CIO to comment, is this HTTP only here? Or could it be HTTPS also?
Probably worth adding tests to validate the behaviour for both cases.
Some extra context for OkHttp. We position it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be HTTP or HTTPS here. Thanks for your explanation, especially for the second point.