Created 'User filters' view in admin. Improved admin 'Lectures' view. #102
Conversation
There was a problem hiding this comment.
Looks good to me. I will manual test it and as soon @ref-humbold reviews, we can get this merged
app/src/users/admin.py
Outdated
|
|
||
| def room_name(self, obj): | ||
| return obj._room_name | ||
| # Implementation have M2M Fields, only first record of room_of_user is taken in list_csv_room_by_member, what if many rooms defined? |
There was a problem hiding this comment.
FYI: I think it shouldn't be a problem as in middle table UserRoom users are related by OneToOneField :)
There was a problem hiding this comment.
Oh, indeed. Then members=ManyToManyField is confusing (because in reality it's not M2M). I suggest removing it, because associative table does what we need.
| # Implementation have M2M Fields, only first record of room_of_user is taken in list_csv_room_by_member, what if many rooms defined? | ||
| room_name.admin_order_field = '_room_name' | ||
|
|
||
| def payment_accepted(self, obj): # FK from Many site, User can have many UserPreferences. Maybe link with related id should be provided. |
|
I tested the changes manually. I didn't find any bugs. Everything seems great from user/organizer POV. |
…st_csv_members_by_room view.
There was a problem hiding this comment.
Thanks for your contribution! It's great to see students contributing to this project. I also tested it manually and I took a look into source code. Everything works great 👍, however I want to highlight that only a very small group of people have access to the Django admin site. Most organizers have access only to the "admin panel" and features like that will be useful there too 😉
Anyway I approve this PR and I look forward to see the next ones 👍
No description provided.