Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Configure CodeQL #116

Merged
merged 3 commits into from
Oct 30, 2023
Merged

chore: Configure CodeQL #116

merged 3 commits into from
Oct 30, 2023

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Oct 28, 2023

Configure CodeQL vulnerability scans

@ckadner
chore: Configure CodeQL
23c4163 
Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner requested a review from rafvasq October 28, 2023 07:06
@ckadner ckadner marked this pull request as draft October 28, 2023 07:08
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ckadner
Setup Java
b543f99 
Signed-off-by: Christian Kadner <[email protected]>
@ckadner
Don't need etcd
7afeb99 
Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner marked this pull request as ready for review October 28, 2023 07:38
rafvasq
rafvasq approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rafvasq rafvasq merged commit c3f018f into main Oct 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafvasq rafvasq rafvasq approved these changes

@njhill njhill Awaiting requested review from njhill

@tjohnson31415 tjohnson31415 Awaiting requested review from tjohnson31415

Assignees

@rafvasq rafvasq

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckadner @kserve-oss-bot @rafvasq