Add pathTemplate field to values.yaml for increased flexibility of helm chart #4237
Conversation
| @@ -273,7 +274,7 @@ data: | |||
| # Namespace of the inference service ( {{- "{{ .Namespace }}" -}} ) | |||
| # For more info https://github.com/kserve/kserve/issues/2257. | |||
| # NOTE: This configuration only applicable to serverless deployment. | |||
| "pathTemplate": "/serving/{{ .Namespace }}/{{ .Name }}" | |||
| "pathTemplate": "" | |||
There was a problem hiding this comment.
IMO this is just an example that shows how to use the placeholders, and can stay unchanged. The previous block where you added this field should be enough to show what is the default value.
There was a problem hiding this comment.
I think can keep it as example for reference.
| @@ -154,6 +154,9 @@ kserve: | |||
| # -- Ingress domain template for RawDeployment mode, for Serverless mode it is configured in Knative. | |||
| domainTemplate: "{{ .Name }}-{{ .Namespace }}.{{ .IngressDomain }}" | |||
|
|
|||
| # -- Path template for RawDeployment mode, for Serverless mode it is configured in Knative. | |||
There was a problem hiding this comment.
I'm confused, because the comments of the configmap.yaml that you also changed tell this field is for Serverless. But, here, you say it is for Raw. Either, here is wrong, or configmap.yaml is wrong.
There was a problem hiding this comment.
@DeepFlame-JR path based routing is supported in both serverless and raw deployment (with gateway api).
|
Hi @DeepFlame-JR can you sign off your commit |
|
@lizzzcai @israel-hdez @sivanantha321 |
| @@ -272,7 +273,7 @@ data: | |||
| # Name of the inference service ( {{- "{{ .Name }}" -}} ) | |||
| # Namespace of the inference service ( {{- "{{ .Namespace }}" -}} ) | |||
| # For more info https://github.com/kserve/kserve/issues/2257. | |||
| # NOTE: This configuration only applicable to serverless deployment. | |||
| # If path template is empty the default path template is "" | |||
There was a problem hiding this comment.
I think this line is confusing. It should be something like If the path template is an empty string "" then path based routing is disabled.
| @@ -154,6 +154,9 @@ kserve: | |||
| # -- Ingress domain template for RawDeployment mode, for Serverless mode it is configured in Knative. | |||
| domainTemplate: "{{ .Name }}-{{ .Namespace }}.{{ .IngressDomain }}" | |||
|
|
|||
| # -- Path template for RawDeployment mode, for Serverless mode it is configured in Knative. | |||
There was a problem hiding this comment.
| # -- Path template for RawDeployment mode, for Serverless mode it is configured in Knative. | |
| # -- pathTemplate specifies the template for generating path based url for each inference service. If the value is an empty string, then path based routing will be disabled. | |
What this PR does / why we need it:
Which issue(s) this PR fixes
Type of changes
Release note: