Add option to order results by last commit date #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @CLiu13, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: 2c64fc40-eac6-11e8-8440-8fa58700f614 |
kx-chen
suggested changes
Nov 18, 2018
jayvdb
requested changes
Nov 18, 2018
CLiu13
force-pushed
the
commit-date
branch
2 times, most recently
from
6a3f1df
to
c8ebd92
Compare
Travis tests have failedHey @CLiu13, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: 4d29d910-eaf7-11e8-8440-8fa58700f614 |
Travis tests have failedHey @CLiu13, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: c1a72ae0-eaf7-11e8-8440-8fa58700f614 |
Travis tests have failedHey @CLiu13, 1st BuildpytestTravisBuddy Request Identifier: 40d80cd0-eaf8-11e8-8440-8fa58700f614 |
Travis tests have failedHey @CLiu13, 1st BuildpytestTravisBuddy Request Identifier: 31a58ed0-eaf9-11e8-8440-8fa58700f614 |
Travis tests have failedHey @CLiu13, 1st BuildpytestTravisBuddy Request Identifier: 1a8bc010-eafa-11e8-8440-8fa58700f614 |
jayvdb
requested changes
Nov 18, 2018
Travis tests have failedHey @CLiu13, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: c3c73bf0-ebcc-11e8-aa09-4ba844902889 |
Travis tests have failedHey @CLiu13, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: 9f1581d0-ebcd-11e8-aa09-4ba844902889 |
Travis tests have failedHey @CLiu13, 1st BuildpytestTravisBuddy Request Identifier: 8f42a520-ebce-11e8-aa09-4ba844902889 |
This adds the ability to clone every repo (which can be used for other purposes later) and determine the date of the last commit, which is then recorded and can be used to sort the export results. Closes ksdme#7
ksdme
reviewed
Nov 19, 2018
|
|
||
| def _get_last_commit_date(self): | ||
| repo_commit_dates = [''] | ||
| for commit in self.commits: |
There was a problem hiding this comment.
So, this will not work with --use-repo-list mode from #34, right?
There was a problem hiding this comment.
Why iterate over every commit?
That is horribly inefficient.
Any list of commits should be already pre-sorted, most recent first, so you should be able to get only the first using next(iter(commit_list))
There was a problem hiding this comment.
If there is a problem in the GitLabRepository implementation, that needs to be solved upstream in IGitt.
If so, add a comment here in this PR explaining the problem, and we'll check and you can create an issue and solve the IGitt bug.
There was a problem hiding this comment.
Yes, the list of commits is not pre-sorted.
There was a problem hiding this comment.
Ok, we'll get IGitt fixed so this doesnt need to be so ugly.
| @@ -21,6 +22,9 @@ def __init__(self, token, group, **kargs): | |||
| self._token = GitHubToken(token) | |||
| self._org = GitHubOrganization(self._token, self._group) | |||
|
|
|||
| for repo in self._org.repositories: | |||
| repo.get_last_commit_date = MethodType(_get_last_commit_date, repo) | |||
There was a problem hiding this comment.
I don't like how you are patching in a method here. We already have support for Gitman and once your #34 gets merged we will support --use-repo-list. This method will work when the merge happens.
At this point of time, we have two ways to address this problem.
- Provide a static method on
OrgHostto get the commit dates of a given repo independently. - We already support tools like Gitman, we can use them to clone the repos and get commit dates from the local copy.
jayvdb
requested changes
Nov 20, 2018
|
|
||
| def _get_last_commit_date(self): | ||
| repo_commit_dates = [''] | ||
| for commit in self.commits: |
There was a problem hiding this comment.
If there is a problem in the GitLabRepository implementation, that needs to be solved upstream in IGitt.
If so, add a comment here in this PR explaining the problem, and we'll check and you can create an issue and solve the IGitt bug.
|
The current approach to this issue involves getting a list of commits from Gitlab by using Igitt. This list of commits is unsorted due to Igitt's implementation of this, which returns the list of commits as a set, causing it to be randomly shuffled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to clone every repo (which
can be used for other purposes later) and determine
the date of the last commit, which is then recorded
and can be used to sort the export results.
Closes #7