meson: Add 'werror=true' to enable -Werror #14
Conversation
|
|
|
Wait for #15 to be merged |
| /** | ||
| * Mark argument as `unused`, for example when developing unimplemented functions | ||
| */ | ||
| #define UNUSED(__ARG) __attribute__((__unused__)) __ARG |
There was a problem hiding this comment.
why do we need an __ARG ? ( just expand UNUSED -> attribute((unused)) )
| #define UNUSED(__ARG) __attribute__((__unused__)) __ARG | ||
|
|
||
| /** | ||
| * Create a unique phantom member to a struct to avoid empty structs. |
There was a problem hiding this comment.
why do we need to avoid empty struct ?
There was a problem hiding this comment.
ISO C does not allow empty structs
There was a problem hiding this comment.
ISO C always doesn't have __FUNCTION__ do we really want ISO C ?
| @@ -1,8 +1,10 @@ | |||
| project('ubsh', 'c', | |||
| default_options: [ | |||
| 'warning_level=3', | |||
| 'werror=true', | |||
There was a problem hiding this comment.
I'm not a big fan of Werror, I like to see the difference between actual errors and warnings
There was a problem hiding this comment.
That's fair. I don't really mind, not using Werror also makes for faster development. I'm just against warnings
There was a problem hiding this comment.
I'm also not a fan of Werror. I've seen too many project which did not compile because of an update of GCC bringing a new warning and the project used Werror.
No description provided.