Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test alternative query param generation #28

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bencromwell
Copy link
Collaborator

@bencromwell bencromwell commented Sep 4, 2024

Jane's current version uses

return sprintf(' *     @var %s $%s %s', $type, $parameter->getName(), $parameter->getDescription() ?: '');

This changes it to use

return sprintf(
            ' *      \'%s\': %s,%s',
            $parameter->getName(),
            $type,
            $parameter->getDescription() ? ' ' . $parameter->getDescription() : ''
        );

The result is in the diff of this PR, a representative sample is:

    /*
     * @param array $queryParameters {
     *
     * @var string $certificate[id] All 'certificate[]' params are mutually exclusive, only one can be provided.
     *             }
     */

which becomes

   /*
     * @param array $queryParameters {
     *                               'certificate[id]': string, All 'certificate[]' params are mutually exclusive, only one can be provided.
     *                               }
     */

@bencromwell bencromwell changed the base branch from main to feat/kp-2.54.0 September 4, 2024 12:37
Copy link

github-actions bot commented Sep 4, 2024

Download Reports

Download the OpenAPI Changes Report

Core API Changes

├─┬Paths
│ ├──[➕] path (7441:5)
│ ├──[➕] path (7770:5)
│ ├──[➕] path (1220:5)
│ ├─┬/organizations/organization/virtual_machines/build
│ │ └─┬POST
│ │   ├─┬Responses
│ │   │ └─┬422
│ │   │   └─┬application/json
│ │   │     └─┬Schema
│ │   │       └──[🔀] $ref (16690:18)❌ 
│ │   └─┬Requestbody
│ │     └─┬application/json
│ │       └─┬Schema
│ │         └──[➕] properties (11237:19)
│ └─┬/virtual_machine_packages
│   └─┬GET
│     └─┬Responses
│       └─┬200
│         └─┬application/json
│           └─┬Schema
│             └─┬virtual_machine_packages
│               └─┬Schema
│                 └──[🔀] $ref (15551:17)❌ 
└─┬Components
  ├──[➖] responses (20905:48)❌ 
  ├──[➕] responses (21301:69)
  ├──[➕] responses (20911:69)
  ├──[➕] responses (20921:33)
  ├──[➖] schemas (16587:44)❌ 
  ├──[➖] schemas (16550:69)❌ 
  ├──[➖] schemas (16281:53)❌ 
  ├──[➕] schemas (13055:42)
  ├──[➕] schemas (12755:36)
  ├──[➕] schemas (16689:74)
  ├──[➕] schemas (13070:42)
  ├──[➕] schemas (16674:38)
  ├──[➕] schemas (15604:37)
  ├──[➕] schemas (16668:36)
  ├──[➕] schemas (13041:36)
  ├──[➕] schemas (16407:43)
  ├──[➕] schemas (13076:44)
  ├──[➕] schemas (13091:74)
  ├──[➕] schemas (12805:35)
  ├──[➕] schemas (13049:40)
  ├──[➕] schemas (13101:29)
  ├─┬GetDiskTemplate200ResponseDiskTemplate
  │ └──[➕] properties (14957:11)
  ├─┬VirtualMachinePackage
  │ └──[➕] properties (15592:11)
  ├─┬DiskTemplate
  │ └──[➕] properties (13468:11)
  └─┬GetOrganizationDiskTemplates200ResponseDiskTemplates
    └──[➕] properties (14848:11)

Document Element Total Changes Breaking Changes
paths 6 2
components 25 4

Date: 09/04/24 | Commit: New: katapult-core-openapi.json, Original: /tmp/katapult-core-openapi.json

  • BREAKING Changes: 6 out of 31
  • Modifications: 2
  • Removals: 4
  • Additions: 25
  • Breaking Removals: 4
  • Breaking Modifications: 2

ERROR: breaking changes discovered

Public API Changes

└─┬Components
  ├──[➕] schemas (742:37)
  └─┬VirtualMachinePackage
    └──[➕] properties (707:11)

Document Element Total Changes Breaking Changes
components 2 0

Date: 09/04/24 | Commit: New: katapult-public-openapi.json, Original: /tmp/katapult-public-openapi.json

  • Total Changes: 2
  • Additions: 2

Base automatically changed from feat/kp-2.54.0 to main September 5, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant