Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included crawler service demo #92

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Included crawler service demo #92

merged 11 commits into from
Oct 16, 2024

Conversation

chandrams
Copy link
Contributor

No description provided.

@chandrams chandrams self-assigned this Sep 10, 2024
@chandrams chandrams marked this pull request as draft September 10, 2024 15:22
@chandrams chandrams marked this pull request as ready for review September 19, 2024 07:21
@chandrams chandrams added this to the Kruize 0.0.26 Release milestone Sep 19, 2024
@dinogun
Copy link
Contributor

dinogun commented Oct 7, 2024

@chandrams Can you please all of the common code between the various local monitoring demos to one place and not duplicate the code. I dont think we need most of the code that is present in this PR

chandrams and others added 9 commits October 10, 2024 16:50
Signed-off-by: Chandrakala Subramanyam <[email protected]>
Signed-off-by: Chandrakala Subramanyam <[email protected]>
Signed-off-by: Chandrakala Subramanyam <[email protected]>
Signed-off-by: Chandrakala Subramanyam <[email protected]>
Signed-off-by: Chandrakala Subramanyam <[email protected]>
Signed-off-by: Chandrakala Subramanyam <[email protected]>
@chandrams
Copy link
Contributor Author

@dinogun - I have updated the bulk API as per the latest code changes and moved the common code out. Please review.

@dinogun
Copy link
Contributor

dinogun commented Oct 11, 2024

@chandrams Please update the README.md and add content on the bulk API demo goals. Ideally bulk APIs are going to be more useful to users than the individual APIs as users can get recommendations for individual workloads or groups of them by fiddling with the filter. I'd suggest adding enough documentation around this to enable users to tweak the input JSON to achieve whatever they are interested.

Also in a separate PR, we can have additional examples of various bulk input json's that will enable users to get the right kind of recommendations

Signed-off-by: Chandrakala Subramanyam <[email protected]>
@chandrams
Copy link
Contributor Author

@dinogun - I have updated the readme for bulk demo, please review.

Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun dinogun merged commit 907ea80 into kruize:main Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants