-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding demo for namespace recommendations #86
Conversation
@chandrams created a different script for namespace demo and to use test-multiple-import namespace. |
In the recommendations json output, can you remove the namespace name as it repeated and use underscore in namespaceRecommendations to keep it consistent
|
Updated the format according to the document. |
@shekhar316 - Can you resolve the conflicts & update documentation |
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
83b0717
to
c1b8b0e
Compare
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
@shekhar316 Please fix the conflicts |
Resolved the conflicts. |
@shekhar316 I would suggest to not have a separate script for namespace, it is better if this is part of the |
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
Sure, I have updated the demo to use the single script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Namespace Recommendations Demo
Image: http://quay.io/rh-ee-shesaxen/autotune/kruize-namespacetest-v5
Note: