fix: support productRef when removing files
#353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the exception below:
```
File "pbxproj/pbxextensions/ProjectFiles.py", line 332, in remove_file_by_id
if build_file.fileRef == file_ref.get_id():
AttributeError: 'PBXBuildFile' object has no attribute 'fileRef'
```
Fixes kronenthaler#352
Comment on lines
+342
to
+346
| if len([ | ||
| True | ||
| for x in self.objects.get_objects_in_section('PBXBuildFile') | ||
| if hasattr(x, 'fileRef') == file_ref.get_id() | ||
| ]) != 0: |
There was a problem hiding this comment.
Suggested change
| if len([ | |
| True | |
| for x in self.objects.get_objects_in_section('PBXBuildFile') | |
| if hasattr(x, 'fileRef') == file_ref.get_id() | |
| ]) != 0: | |
| if len([1 for x in self.objects.get_objects_in_section('PBXBuildFile') if hasattr(x, 'fileRef') && x.fileRef == file_ref.get_id()]) != 0: |
kronenthaler
merged commit 78e45a5
into
kronenthaler:fix-remove-files
0 of 5 checks passed
|
@OmarIthawi thanks for the contribution |
|
Thanks @kronenthaler a lot for the quick triage!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the exception below:
Fixes #352