Skip to content

Commit

Permalink
refactor: standardize kro capitalization to lowercase
Browse files Browse the repository at this point in the history
No functional changes were made.
  • Loading branch information
a-hilaly committed Nov 11, 2024
1 parent 087c850 commit c3cdc36
Show file tree
Hide file tree
Showing 29 changed files with 522 additions and 374 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ body:
**Reproduction Steps** (Please include `ResourceGroup` and `Instances` files):
**Versions**:
- KRO Version:
- kro version:
- Kubernetes Version (`kubectl version`):
**Involved Controllers**:
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,13 @@ $(CONTROLLER_GEN): $(LOCALBIN)
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@$(CONTROLLER_TOOLS_VERSION)

.PHONY: image
build-image: ## Build the KRO controller images using ko build
build-image: ## Build the kro controller images using ko build
$(WITH_GOFLAGS) KOCACHE=$(KOCACHE) KO_DOCKER_REPO="095708837592.dkr.ecr.us-west-2.amazonaws.com/kro" \
ko build --bare github.com/awslabs/kro/cmd/controller \
--push=false --tags ${RELEASE_VERSION} --sbom=none

.PHONY: publish
publish-image: ## Publish the KRO controller images to ECR
publish-image: ## Publish the kro controller images to ECR
$(WITH_GOFLAGS) KOCACHE=$(KOCACHE) KO_DOCKER_REPO="095708837592.dkr.ecr.us-west-2.amazonaws.com/kro" \
ko publish --bare github.com/awslabs/kro/cmd/controller \
--tags ${RELEASE_VERSION} --sbom=none
Expand Down
6 changes: 3 additions & 3 deletions api/v1alpha1/conditions.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ type ConditionType string

const (
// ResourceGroupConditionTypeGraphSynced indicates the state of the directed
// acyclic graph (DAG) that KRO uses to manage the resources in a
// acyclic graph (DAG) that kro uses to manage the resources in a
// ResourceGroup.
ResourceGroupConditionTypeGraphVerified ConditionType = "kro.aws.dev/GraphVerified"
// ResourceGroupConditionTypeCustomResourceDefinitionSynced indicates the state of the
// CustomResourceDefinition (CRD) that KRO uses to manage the resources in a
// CustomResourceDefinition (CRD) that kro uses to manage the resources in a
// ResourceGroup.
ResourceGroupConditionTypeCustomResourceDefinitionSynced ConditionType = "kro.aws.dev/CustomResourceDefinitionSynced"
// ResourceGroupConditionTypeReconcilerReady indicates the state of the reconciler.
// Whenever an ResourceGroup resource is created, KRO will spin up a
// Whenever an ResourceGroup resource is created, kro will spin up a
// reconciler for that resource. This condition indicates the state of the
// reconciler.
ResourceGroupConditionTypeReconcilerReady ConditionType = "kro.aws.dev/ReconcilerReady"
Expand Down
2 changes: 1 addition & 1 deletion examples/ack-controller/ec2-controller/ec2-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
iamRole:
maxSessionDuration: integer | default=3600
oidcProvider: string | required=true
roleDescription: string | default=IRSA role for ACK EC2 controller deployement on EKS cluster using KRO Resource group
roleDescription: string | default=IRSA role for ACK EC2 controller deployement on EKS cluster using kro Resource group
image:
deletePolicy: string | default=delete
repository: string | default=public.ecr.aws/aws-controllers-k8s/ec2-controller
Expand Down
2 changes: 1 addition & 1 deletion examples/ack-controller/eks-controller/eks-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
iamRole:
maxSessionDuration: integer | default=3600
oidcProvider: string | required=true
roleDescription: string | default=IRSA role for ACK EKS controller deployement on EKS cluster using KRO Resource group
roleDescription: string | default=IRSA role for ACK EKS controller deployement on EKS cluster using kro Resource group
iamPolicy:
# would prefer to add a policyDocument here, need to support multiline string here
description: string | default="policy for eks controller"
Expand Down
Loading

0 comments on commit c3cdc36

Please sign in to comment.